Ported an app from UWP to WinUI3 and noticed a bunch of UI 'corruption' in our TreeView control when filtering elements. Tracked it down to TreeView.RootNodes().RemoveAtEnd() always removing the first item instead of the last item, which means you are left with a totally unexpected result, as well as being unable to remove all the items due to never being able to remove index 0.

The bug is due to incorrect parameter passing (ideally unused stack variable warnings would be enabled and would catch this), where index was intialized, but never passed to RemoveAt, causing theupdateItemsSource boolean to stand in for an index, causing us to always delete index 0 or 1 instead of N-1.

The workaround is to just manually use RemoveAt instead of RemoveAtEnd.

Description

Pass index to RemoveAtIndex call.

Motivation and Context

RemoveAtEnd is totally unusable on TreeView Nodes collections.

How Has This Been Tested?

I have not built or tested this, as the links to setting up and building this repo in theSetup and build environment section of the contributing document is a dead link, and the change is pretty straightforward.

Screenshots (if appropriate):

N/A

RemoveAtEnd on TreeViewNodeVector broken

596236a

Ported an app from UWP to WinUI3 and noticed a bunch of UI 'corruption'in our TreeView control when filtering elements. Tracked it down toTreeView.RootNodes().RemoveAtEnd() always removing the first iteminstead of the last item, which means you are left with a totallyunexpected result, as well as being unable to remove all the items dueto never being able to remove index 0.The bug is due to incorrect parameter passing (ideally unused stackvariable warnings would be enabled and would catch this), where indexwas intialized, but never passed to RemoveAt, causing the`updateItemsSource` boolean to stand in for an index, causing us toalways delete index 0 or 1 instead of N-1.The workaround is to just manually use RemoveAt instead of RemoveAtEnd.