Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] Chat launcher experience#5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
compulim wants to merge23 commits intomain
base:main
Choose a base branch
Loading
fromfeat-chat-launcher
Draft

Conversation

@compulim
Copy link
Contributor

@compulimcompulim commentedOct 14, 2025
edited
Loading

Fixes #

Changelog Entry

Description

Design

Build scripts changes

  • npm run build:pre will rewritepackage.json/localDependencies andpackage.json/scripts/start
    • scripts/start is computed and overwrite automatically 🥳
    • By overwriting things directly inpackage.json, we can see what it will run against
  • npm run start actually runnpm run build:run once and exit, notsup --watch
    • Will pick up new changes intsup.config.ts 🥳
    • Build error will be retried on next file change, no more silent build stop 🥳
  • Useinotifywatch to watch for changes
    • No initial build, devs must runnpm run build themselves first 🥳
  • It still use brute-force to "keep rebuilding until no files change"
    • I don't want to build a complex "what need to build first/last" script right now
  • Trigger next package by touchingpackage.json, right after ESM is built
    • It was waiting until all CJS + ESM + DTS is done... I think we only need ESM is done is fine... tweakable
    • tsup --onSuccess will be triggered twice, one for CJS and one for ESM
  • DTS easily takes ~20 seconds to build
    • dtsroll is inbuild:post:dtsroll, because we don't need it in development environment
  • Why notprebuild/postbuild... because I want to keep--ignore-scripts enabled
  • I also relocated some scripts under/scripts/npm/bump-dev.sh, etc...

Triednodemon andnode --watch, both doesn't work as good asinotifywait. Especially around how it queue up changes while the build is ongoing.inotifywait in shell script is most flexible option.

Specific Changes

-

  • I have added tests and executed them locally
  • I have updatedCHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, noz-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json andpackage-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@a-b-r-o-w-na-b-r-o-w-nAwaiting requested review from a-b-r-o-w-na-b-r-o-w-n will be requested when the pull request is marked ready for reviewa-b-r-o-w-n is a code owner

@cwhittencwhittenAwaiting requested review from cwhittencwhitten will be requested when the pull request is marked ready for reviewcwhitten is a code owner

@srinaathsrinaathAwaiting requested review from srinaathsrinaath will be requested when the pull request is marked ready for reviewsrinaath is a code owner

@tdurnfordtdurnfordAwaiting requested review from tdurnfordtdurnford will be requested when the pull request is marked ready for reviewtdurnford is a code owner

@beyackle2beyackle2Awaiting requested review from beyackle2beyackle2 will be requested when the pull request is marked ready for reviewbeyackle2 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@compulim

[8]ページ先頭

©2009-2025 Movatter.jp