- Notifications
You must be signed in to change notification settings - Fork1.1k
logging: Addhandler param tobasicConfig.#1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
logging: Addhandler param tobasicConfig.#1023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stinos commentedJun 11, 2025
It seems like a small step to just support |
I could do that, yeah. My thought was that for an MCU more than one handler is unlikely, but I agree that compatibility means that everyone feels more comfortable using Micropython. |
Josverl commentedJun 12, 2025
I agree that handlers = [] is simpler to learn , |
CPython allows specifying a list of handlers in the initialization oflogging with basicConfig(handlers=<iterable>). This adds similar supportto Micropython. It allows to initialize logging with a set ofspecialized handlers.Signed-off-by: Jared Hancock <jared@greezybacon.me>
9d4e1ae to25185a5CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a nice enhancement, but the implementation doesn't work.
We really need some unittests for thelogging module.
| handler=StreamHandler(stream) | ||
| else: | ||
| handler=FileHandler(filename,filemode,encoding) | ||
| ifhandlersisNone: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This doesn't seem right:handlers is neverNone unless explicitly passed in. Maybe you meantif not handlers?
| handler.setLevel(level) | ||
| handler.setFormatter(Formatter(format,datefmt)) | ||
| forhandlerinlogging.handlers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
logging is not defined in this scope.
| handler.setFormatter(Formatter(format,datefmt)) | ||
| logger.setLevel(level) | ||
| logger.addHandler(handler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It looks like the default handler (if none specified) is never added?
CPython allows specifying a list of handlers in the initialization of logging with basicConfig(handlers=). This adds similar support but only with a single handler. It allows to initialize logging with a single, specialized handler.