Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.5k
tests: Factor out common helper functions to separate Python module.#18313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
dpgeorge wants to merge1 commit intomicropython:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+412 −364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedOct 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #18313 +/- ##======================================= Coverage 98.39% 98.39% ======================================= Files 171 171 Lines 22290 22290 ======================================= Hits 21933 21933 Misses 357 357 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1b16b20 to9dbdb81CompareThe test runners have evolved over time and become more and more complex.In particular `tests/run-tests.py` is rather large now. The test runnersalso duplicate some functionality amongst themselves.As a start to improving this situation, this commit factors out the helperfunctions from `run-tests.py` into a new `test_utils.py` file, and usesthat new module in all test runners.There should be no functional change here.Signed-off-by: Damien George <damien@micropython.org>
9dbdb81 to3928f3eCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test runners have evolved over time and become more and more complex. In particular
tests/run-tests.pyis rather large now. The test runners also duplicate some functionality amongst themselves.The grand idea is to consolidate them, factor code and eliminate duplication. To start that process, this PR just factors out the helper functions from
run-tests.pyinto a newtest_utils.pyfile, and uses that new module in all test runners.There should be no function change here.
Testing
Tested locally, running all test runners on the unix port and a board.
Will also be tested by CI.
Trade-offs and Alternatives
Open to suggestions for the name of the helper module (currently
test_utils.py).