- Notifications
You must be signed in to change notification settings - Fork77
WIP: ISO7816/CEPAS speed-ups to make Android Pay work#705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
micolous wants to merge2 commits intometrodroid:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| } catch (e: Exception) { | ||
| null | ||
| null // but continue | ||
| } | ||
| val records : MutableMap<Int, ImmutableByteArray> = mutableMapOf() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this part and its dependencies can be committed. Not sure how I feel about skipping SFI dumping though
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CEPAS: removes early
dumpAllSfis. This saves about 1.6 sec reading CEPAS and EMV cards. The data here is never actually used by Metrodroid as far as I can tell, and it isalso available in other places::3f00:4000:10:3f00:4000:16:3f00:4000:17EMV: Makes the GPO authorised for USD 0.00, rather than USD 0.01
ISO: Add some more error conditions, and bail out earlier on
file not foundandsecurity status not satisfiedEMV: Bail out early when reading if the first batch of SFIs returns null 3/3, rather than continuing to read (which helps with Android Pay)
This seems to be good enough to let
jvmclisort-of read from Android Pay EMV -- it does time out in a later stage, but pulling the phone away from the reader still shows valid data.I'm still able to read a CEPAS not affected by#366 in jvmcli with this patch.
I still need to do some more testing on this to ensure nothing else broke.