Commit89abe7e

oschwald

and

claude

committed

Modernize setup.py for Python 3.10+

- Replace sys.exc_info() with modern exception handling using 'from' clause- Use text mode when opening files instead of binary mode with manual decode- Update BuildFailed to accept exception parameter for proper chainingThese are internal improvements with no user-visible changes.🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>

1 parent29b4f3c commit89abe7eCopy full SHA for 89abe7e

File tree

1 file changed

+14

-13

lines changed

setup.py

1 file changed

+14

-13

lines changed

`‎setup.py‎`

Lines changed: 14 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@`
`65`	`65`
`66`	`66`
`67`	`67`	`classBuildFailed(Exception):`
`68`		`-def__init__(self)->None:`
`69`		`-self.cause=sys.exc_info()[1]`
	`68`	`+def__init__(self,cause:Exception)->None:`
	`69`	`+super().__init__()`
	`70`	`+self.cause=cause`
`70`	`71`
`71`	`72`
`72`	`73`	`classve_build_ext(build_ext):`
`@@ -75,18 +76,18 @@ class ve_build_ext(build_ext):`
`75`	`76`	`defrun(self)->None:`
`76`	`77`	`try:`
`77`	`78`	`build_ext.run(self)`
`78`		`-exceptPlatformError:`
`79`		`-raiseBuildFailed`
	`79`	`+exceptPlatformErrorasex:`
	`80`	`+raiseBuildFailed(ex)fromex`
`80`	`81`
`81`	`82`	`defbuild_extension(self,ext)->None:`
`82`	`83`	`try:`
`83`	`84`	`build_ext.build_extension(self,ext)`
`84`		`-exceptext_errors:`
`85`		`-raiseBuildFailed`
`86`		`-exceptValueError:`
	`85`	`+exceptext_errorsasex:`
	`86`	`+raiseBuildFailed(ex)fromex`
	`87`	`+exceptValueErrorasex:`
`87`	`88`	`# this can happen on Windows 64 bit, see Python issue 7511`
`88`		`-if"'path'"instr(sys.exc_info()[1]):`
`89`		`-raiseBuildFailed`
	`89`	`+if"'path'"instr(ex):`
	`90`	`+raiseBuildFailed(ex)fromex`
`90`	`91`	`raise`
`91`	`92`
`92`	`93`
`@@ -95,11 +96,11 @@ def build_extension(self, ext) -> None:`
`95`	`96`
`96`	`97`	`ROOT=os.path.dirname(__file__)`
`97`	`98`
`98`		`-withopen(os.path.join(ROOT,"README.rst"),"rb")asfd:`
`99`		`-README=fd.read().decode("utf8")`
	`99`	`+withopen(os.path.join(ROOT,"README.rst"),encoding="utf-8")asfd:`
	`100`	`+README=fd.read()`
`100`	`101`
`101`		`-withopen(os.path.join(ROOT,"maxminddb","__init__.py"),"rb")asfd:`
`102`		`-maxminddb_text=fd.read().decode("utf8")`
	`102`	`+withopen(os.path.join(ROOT,"maxminddb","__init__.py"),encoding="utf-8")asfd:`
	`103`	`+maxminddb_text=fd.read()`
`103`	`104`	`VERSION= (`
`104`	`105`	`re.compile(r".__version__ = \"(.?)\"",re.DOTALL)`
`105`	`106`	`.match(maxminddb_text)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit89abe7e

File tree

1 file changed

1 file changed

`‎setup.py‎`

0 commit comments