NotificationsYou must be signed in to change notification settings
Fork27
Star295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Bridge discord messages sent with @silent as m.notice#168

Open

ginnyTheCat wants to merge1 commit intomautrix:main

base:main

Choose a base branch

fromginnyTheCat:silent

Open

Bridge discord messages sent with @silent as m.notice#168

ginnyTheCat wants to merge1 commit intomautrix:mainfromginnyTheCat:silent

+5 −0

Conversation

Copy link

Contributor

ginnyTheCat commentedDec 8, 2024•
edited
Loading

Bridges discord messages marked as@silent as matrix notices.

Notice the bell icon in the corner

sumnerevans reviewed

Dec 11, 2024

View reviewed changes

Copy link

Member

sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Probably the more correct way to bridge these is as normal messages with an emptym.mentions so that nobody gets mentioned.

Copy link

ContributorAuthor

ginnyTheCat commentedDec 11, 2024

As far as I understand an emptym.mentions still sends a notification, just not a ping. While a discord silent messages won't send any notification even if explicitly enabled in the room. Idk if this is realizable some other way than am.notice.

Copy link

Member

tulir commentedDec 11, 2024

m.notice doesn't necessarily disable notifications, it's just a marker for automated messages. Bridging@silent properly probably needs a new MSC to define a new field to signal silent messages and a corresponding push rule