Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Mar 5, 2023. It is now read-only.

Regenerate compiled files on yarn/npm reinstall#68

Open
danielkcz wants to merge1 commit intomattpocock:master
base:master
Choose a base branch
Loading
fromdanielkcz:postinstall-watch

Conversation

@danielkcz
Copy link

Replacement for PR#60 (somehow I messed up rebase).

@changeset-bot
Copy link

🦋 Changeset detected

Latest commit:a79de91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
xstate-codegenPatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielkczdanielkcz mentioned this pull requestDec 19, 2020
Copy link
Owner

@mattpocockmattpocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@FredyC Carrying on conversation here.

My work uses a yarn workspaces monorepo. When I runxstate-codegen insidepackage-name, then add a new package at root, thepackage-name/node_modules/@xstate/compiled folder is removed, but the codegen does not re-run.

What can be changed to make sure this case is picked up?

@danielkcz
Copy link
Author

danielkcz commentedDec 19, 2020
edited
Loading

@mattpocock I am not sure I understand your use case. You are not running xstate-codegen in the root?

I mean there isn't really anything magical about this solution. It simple usesgetTargetDir() to find generatedpackage.json file and when that gets deleted, it will write all generated files again. Watching over the whole folder wasn't working for some reason.

@mattpocock
Copy link
Owner

@FredyC OK - that makes sense. I'll see if I can get it working for my use case.

You are not running xstate-codegen in the root?

Correct. There is a node_modules folder at the root and a node_modules folder insidepackage-name. I'll investigate more.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@mattpocockmattpocockmattpocock requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielkcz@mattpocock

[8]ページ先頭

©2009-2025 Movatter.jp