Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
FIX: Keep legacy alpha behavior for violinplot without facecolor#30636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
3c87254 to520c6c7Comparelib/matplotlib/axes/_axes.py Outdated
| You can use the ``(color, alpha)`` tuple notation to pass | ||
| semi-transparent colors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Little unclear here, do you mean that (color, alpha) supercedes but does not set the artist alpha? So for example linecolor still used the artist alpha?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Changed to
To set transparency forfacecolor oredgecolor use
(color, alpha)tuples.
520c6c7 tof70a4a2CompareTest failure is our flaky timeout and unrelated to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not clear on why the test sets a facecolor via if statement but otherwise looks good. Thanks for taking care of this.
| # Case 1: If facecolor is unspecified, it's the first color from the color cycle | ||
| # with Artist-level alpha=0.3 | ||
| facecolor= ('y'ifmpl.rcParams['_internal.classic_mode'] | ||
| elseplt.rcParams['axes.prop_cycle'].by_key()['color'][0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why is the color controlled by if statement, rather than fixed, given that this is a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
when debugging this I ran local code snippets until it worked. Then , I turned them into a test, which failed because our tests still use the classic style.
I figured it is reasonable to make the test robust to work with any style even though we are only testing one. It may be that we switch to using our default theme for testing at some point in the future. And it would be a nuisance if that test then falls over and someone has to figure out why.
Closes#30613.