Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: cast Patch linewidth to float for dash scaling#30333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 1 commit intomatplotlib:mainfromrcomer:conpatch-lw
Jul 18, 2025

Conversation

rcomer
Copy link
Member

PR summary

Fixes#30323. The code from#30323 (comment) now produces

image

For now I have not added a test - as noted at#30323 (comment)

The obvious test (set linewidth with a string) would represent a use-case that seems controversial amongst the maintainers, so I am not sure if we want that in there.

PR checklist

@story645story645 added this to thev3.10.4 milestoneJul 18, 2025
@story645
Copy link
Member

test failures seem unrelated, feel free to merge after they're all run (assuming failures stay unrelated) & thanks!

rcomer reacted with thumbs up emoji

@rcomerrcomer merged commitefacc7d intomatplotlib:mainJul 18, 2025
36 of 39 checks passed
@rcomerrcomer deleted the conpatch-lw branchJuly 18, 2025 19:54
@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 efacc7d26c2d378deb097349bd4051ed4bd29032
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #30333: FIX: cast Patch linewidth to float for dash scaling'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-30333-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR#30333 on branch v3.10.x (FIX: cast Patch linewidth to float for dash scaling)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@rcomer
Copy link
MemberAuthor

Conflict seems to be because the next line is wrapped on the bugfix branch

self._dash_pattern=mlines._scale_dashes(
*self._unscaled_dash_pattern,w)

I'm not convinced this is worth a manual backport.

timhoffm reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

[MNT]: validate linewidth
3 participants
@rcomer@story645@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp