Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Pyplot explicit signature#30200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor suggestions, but I'm fine either way.
| *args: float | ArrayLike | str, | ||
| scalex: bool = True, | ||
| scaley: bool = True, | ||
| data=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMHO we could leave data out, because it's not typed anyway, so no advantage of writing it out.
| def polar(*args, **kwargs) -> list[Line2D]: | ||
| def polar( | ||
| *args: float | ArrayLike | str, | ||
| scalex: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would also leavescalex,scaley out. They are an odd wart ofplot. No other plotting method has this and I'd rather not explicitly talk about it inpolar, even if this means it's not type annotated.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
This PR update
lib/matplotlib/pyplot.pyto replace*args, **kwargswith the real signature for the following methods:savefigset_loglevelpolarPR checklist