Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix issue #30164: Removing spines in polar plot causing distortion of…#30194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…tortion of the plot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Thanks for your willingness to contribute. However the fix is not appropriate. First, there’s already an existing pull request, which you can find linked in the original issue. Second, the solution here does not match state of the discussion in the issue. |
… the plot
PR summary
This PR fixes a bug in polar plots (issue#30164), where removing ticks using
set_xticks([])
orset_yticks([])
would distort the aspect ratio.Why is this change necessary?
Removing the ticks should not alter the scaling or appearance of the plot, but currently, it does in polar projections.
What problem does it solve?
It ensures that the radial and angular axes maintain their correct scaling even when ticks are hidden.
Implementation details
The fix modifies
PolarAxes._init_axis()
to ensure that tick visibility no longer affects autoscaling or aspect locking.Minimal example demonstrating the fix:
PR checklist
PR checklist