NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Fix figure legend when drawing stackplots#30186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

dstansby wants to merge1 commit intomatplotlib:main

base:main

Choose a base branch

fromdstansby:fig-legend-error

Draft

Fix figure legend when drawing stackplots#30186

dstansby wants to merge1 commit intomatplotlib:mainfromdstansby:fig-legend-error

Conversation

Copy link

Member

dstansby commentedJun 18, 2025

PR summary

Fixes#30158 - as suggested in#30158 (comment), two calls were trying to set the figure, and Ithink one of them doesn't need to.

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

Fix figure legend when drawing stackplots

e1a820c

github-actionsbot added the topic: legend label

Jun 18, 2025

Copy link

Member

QuLogic commentedJun 19, 2025

Yes, I believe this is correct;HandlerBase.update_prop will set the correct figure (viaLegend._set_artist_props),HandlerPolyCollection._update_prop exists to do the class-specific work of pulling the properties from the first artist in a collection and doesn't need to set the figure.

This could do with a test though.