Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix: Inner circle rendering with log-scale + rorigin in polar plots (Fixes #30179)#30185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bharshavardhanreddy924 wants to merge4 commits intomatplotlib:main
base:main
Choose a base branch
Loading
frombharshavardhanreddy924:fix-polar-log-rorigin

Conversation

bharshavardhanreddy924

✅ Summary

Fixes:#30179

This pull request resolves a rendering issue in polar plots when usingset_yscale("log") together withset_rorigin(...). Previously, when setting a custom radial origin in log scale, the inner circular gridline (representing the minimum radial value) would still be rendered at the center of the polar plot, rather than at the specified origin.

This fix ensures correct rendering of the inner border with proper alignment to the configuredrorigin, even under logarithmic radial scaling.


🔧 What Was Changed?

  • Fixed incorrect rendering logic inprojections/polar.py by updating howrorigin is applied whenlog scale is used.
  • Adjusted transform computation to handle non-zero origins in log scale.

📸 Visual Comparison

BeforeAfterFix

🔁 Replace the image link above with theactual URL GitHub gives you when you drag-and-drop your image into the PR box.


🧪 Minimal Code to Reproduce

importnumpyasnpimportmatplotlib.pyplotaspltr=np.logspace(-1,1,500)theta=np.linspace(0,2*np.pi,500)fig,axs=plt.subplots(1,2,subplot_kw={'projection':'polar'},figsize=(12,6))axs[0].set_title("Before Fix (log + rorigin)")axs[0].set_rscale('log')axs[0].set_rorigin(-0.5)axs[0].plot(theta,r)axs[1].set_title("After Fix (log + rorigin)")axs[1].set_rscale('log')axs[1].set_rorigin(-0.5)axs[1].plot(theta,r)plt.tight_layout()plt.show()

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for opening this. I tried the example code given in the original issue, and this pull request does not solve the issue. Please could you update the pull request so that the issue is fixed, and verify this using the code posted in the original issue?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@dstansbydstansbydstansby requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Inner border is not rendered correctly when using log-scale and polar projection.
2 participants
@bharshavardhanreddy924@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp