Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
savefig's pad_inches specifies per border padding#30183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Added a new padding function to transforms.py, called it in backend_bases, and updated documentation where pad_inches shows up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
I have Also, I didn't do much error checking. The logic is
so if someone puts in a 3-tuple or some other weird datatype it's just going to return some default python error. Up to y'all what the best way to cover that sort of thing is. |
Overlooked a change I made earlier but lost
Uh oh!
There was an error while loading.Please reload this page.
Added a new padding function to transforms.py, called it in backend_bases, and updated documentation where pad_inches shows up
PR summary
Solution for#11764, allowing pad_inches to be set for each border when saving a figure.
Difficult to get compact but suitably bounding borders in savefig with extra artists in some cases
E.g. a plot with broken axes made with subfigures and diagonal lines indicating the break is hard to bound correctly. This adds a crude but simple way to modify the bounding box as needed.
Seems like the simplest way to do it.
PR checklist