Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Scale an image to the axes edges regardless of whether it is being plotted with a nonaffine transform or an affine transform#30175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
ayshih wants to merge2 commits intomatplotlib:mainChoose a base branch fromayshih:nonaffine_scaling
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
This PR fixes a difference between plotting an image with a nonaffine transform versus with an affine transform. When plotting with an affine transform, the transform for rendering gets an additional transform step to scale the image to the axes edges in the situation where the axes bbox is not a whole number of pixels. However, when plotting with a nonaffine transform, this additional scaling step is skipped, and instead the fractional pixel at the end is clipped off. I can't think of any reason why this difference is desirable, so this PR removes the different handling of a nonaffine transform versus an affine transform.
Before this PR
Here's an example image before this PR and generating script. Note that the image plotted using the nonaffine transform has a obvious gap to the axis on the right edge due to the fractional pixel. The discrepancy on the top edge is not quite as obvious.

After this PR
PR checklist