Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TST: Fix runtime error checking NaN input to format_cursor_data#30162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromQuLogic:nan-spacing
Jun 12, 2025

Conversation

QuLogic
Copy link
Member

PR summary

This seems to have changed in NumPy 2.3.0, only on Windows, but there's no reason to not catch this in the test always.

PR checklist

@QuLogic
Copy link
MemberAuthor

Looks like the Python 3.13 builds are hitting the broken installationpython/cpython#135151

Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't the warning catch happen in format_cursor_data (or _format_cursor_data_override) so that it indeed doesn't get emitted when the user mouseovers a nan pixel?
Feel free to dismiss if I missed something.

@QuLogic
Copy link
MemberAuthor

Ah, I wasn't sure if that was something that would happen on purpose; if so, then yes we can move it there.

@anntzer
Copy link
Contributor

@timhoffm Still OK with the new version?

@timhoffmtimhoffm added this to thev3.10.4 milestoneJun 12, 2025
@timhoffmtimhoffm merged commit716d046 intomatplotlib:mainJun 12, 2025
40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 12, 2025
@QuLogicQuLogic deleted the nan-spacing branchJune 12, 2025 19:22
QuLogic added a commit that referenced this pull requestJun 13, 2025
…162-on-v3.10.xBackport PR#30162 on branch v3.10.x (TST: Fix runtime error checking NaN input to format_cursor_data)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.4
Development

Successfully merging this pull request may close these issues.

[Bug]: Test pipeline failure on windows
3 participants
@QuLogic@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp