Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
TYP: Make glyph indices distinct from character codes#30143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
QuLogic wants to merge3 commits intomatplotlib:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+5,406 −4,889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Also, check some expected conditions at parse time instead of somewhereduring use of the data.
Previously, these were both typed as `int`, which means you could mixand match them erroneously. While the character code can't be made adistinct type (because it's used for `chr`/`ord`), typing glyph indicesas a distinct type means these can't be fully swapped.Unfortunately, you can still go back to the base type, so glyph indicesstill work as character codes. But this is still sufficient to catcherrors such as the wrong call to `FT2Font.get_kerning` in`_mathtext.py`.
Note, fixing this would require updating 20 images (for very minimal changes), which I originally rolled into#29816, but it could be moved here. |
The `FontInfo.num` value returned by `TruetypeFonts._get_info` is acharacter code, but `FT2Font.get_kerning` takes *glyph indices*, meaningthat kerning was likely off in most cases.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Previously, these were both typed as
int, which means you could mix and match them erroneously. While the character code can't be made a distinct type (because it's used forchr/ord), typing glyph indices as a distinct type means these can't be fully swapped.Unfortunately, you can still go back to the base type, so glyph indices still work as character codes. But this is still sufficient to catch errors such as the wrong call to
FT2Font.get_kerningin_mathtext.py.This depends on#30134.
PR checklist