Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CI: Skip jobs on forks#30118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromoscargus:forkci
Jun 4, 2025
Merged

CI: Skip jobs on forks#30118

QuLogic merged 1 commit intomatplotlib:mainfromoscargus:forkci
Jun 4, 2025

Conversation

oscargus
Copy link
Member

PR summary

Tests are skipped when pushing changes to a fork, but some other jobs are run. Especially Build CI wheels is a bit unnecessary to run on forks. Also, the CodeQL job is executed periodically on forks, which may lead to emails, but if nothing else waste of compute resources.

PR checklist

@oscargusoscargus added CI: Run cibuildwheelRun wheel building tests on a PR CI: testingCI configuration and testing labelsMay 29, 2025
@tacaswell
Copy link
Member

Only downside is that if you want to use CI to check wheel buliding youmust open a PR or remove the check, but I think that is a reasonable trade off to avoid burning the commute on every push (there is a reason we only do it on PRs in an opt-in basis).

@tacaswell
Copy link
Member

and we might as well backport this to all of our active branches.

@oscargus
Copy link
MemberAuthor

youmust open a PR or remove the check

Although that wasn't part of the plan, I think that one can push the branch to the matplotlib repo to get that. Since the people with push access are the same that are most likely to do that, I think it should be manageable (although a bit of behavior change as most seems to use their private forks. Personally, I always open a PR anyway as I had not thought about the alternative...).

@oscargus
Copy link
MemberAuthor

Btw, it seems like GitHub has disabled workflows on forks by default(?). Some recently cloned repos has a text that says that they are disabled. Makes sense.

GitHub ActionsWorkflows aren’t being run on this forked repositoryBecause this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

Seems to have happened quite recently though.

(Or maybe there is some setting for the main repo? But it seems to correlate with when I forked them, at least a quick check says that.)

@QuLogicQuLogic closed thisJun 4, 2025
@QuLogicQuLogic reopened thisJun 4, 2025
@QuLogicQuLogic merged commit5535df4 intomatplotlib:mainJun 4, 2025
66 of 73 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 4, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 4, 2025
QuLogic added a commit that referenced this pull requestJun 4, 2025
…118-on-v3.10.3-docBackport PR#30118 on branch v3.10.3-doc (CI: Skip jobs on forks)
QuLogic added a commit that referenced this pull requestJun 5, 2025
…118-on-v3.10.xBackport PR#30118 on branch v3.10.x (CI: Skip jobs on forks)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheelRun wheel building tests on a PRCI: testingCI configuration and testing
Projects
None yet
Milestone
v3.10-doc
Development

Successfully merging this pull request may close these issues.

3 participants
@oscargus@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp