Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix label_outer in the presence of colorbars.#30098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| f, axs = plt.subplots(2, 2, sharex=True, sharey=True) | ||
| @pytest.mark.parametrize('with_colorbar', [True, False]) | ||
| def test_label_outer(remove_ticks, with_colorbar): | ||
| fig, axs = plt.subplots(2, 2, sharex=True, sharey=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can this get tested with layout=constrained as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done (but the flagging above with _is_colorbar_gridspec still needs to be done).
add6bbf to045db0fCompareThe subgridspec to be considered should be the one containing both theaxes and the colorbar, not the sub-subgridspec of just the axes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems reasonable to me.
d797ee5 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…0228)Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
The subgridspec to be considered should be the one containing both the axes and the colorbar, not the sub-subgridspec of just the axes.
Closes#27305 (using#27305 (comment) and a test).
PR summary
PR checklist