Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add "sans" alias to rc() to allow users to set font.sans-serif#30030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Thank you for working on this! Can you please add a test that it works as expected? A quick look at This is also a good example of where line coverage is miss-leading: all of the lines are covered but none of the functionality is actually tested! |
I have added tests for the
|
24bcabb
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Thanks for the pr@founta, hope to see you again! |
PR summary
Closes#30021. Previously, users were unable to set font.sans-serif by using keyword arguments to the
rc
function as described in the issue. This change adds thesans
alias tosans-serif
. It appears to function as intended:The change to the alias list in the docstring also appears to be OK:

No tests seemed to fail following this change.
PR checklist