NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

FIX #30007: Raise ValueError when all wedge sizes are zero in ax.pie#30019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

oscargus merged 6 commits intomatplotlib:mainfromalbus-droid:all-zero-ax-pie

May 6, 2025

Merged

FIX #30007: Raise ValueError when all wedge sizes are zero in ax.pie#30019

oscargus merged 6 commits intomatplotlib:mainfromalbus-droid:all-zero-ax-pie

May 6, 2025

Conversation

Copy link

Contributor

albus-droid commentedMay 6, 2025•
edited
Loading

PR summary

Thiscloses#30007,ax.pie will now throw a ValueError when all the wedges are zero , before entering the NaN conversion

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

albus-droid added3 commits

May 6, 2025 02:04

Added a condition that throws a ValueError if all wedges are zero

e9b0d6c

Removed "=" and added "==" for the condition statement

66e50fa

Added a test case with all wedges as zero

cf353c0

github-actionsbot reviewed

May 6, 2025

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link

Member

oscargus commentedMay 6, 2025

Looks good! Can you please fix the linting issues? The best thing in general is to install pre-commit, seehttps://matplotlib.org/devdocs/devel/development_setup.html#install-pre-commit-hooks as that will avoid these things from happening. At the moment you can probably fix it by hand though.