Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix AxesWidgets on inset_axes that are outside their parent.#29966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
anntzer wants to merge1 commit intomatplotlib:mainChoose a base branch fromanntzer:outset-widget
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When axes are overlapping, LocationEvent.inaxes can point not to theaxes we care about, but to another one. Widgets currently recomputelocation event axes coordinates relative to the axes to which the widgetis assigned, but this recomputation code was previously brittle wrt.events that are outside the axes they wrongly believe they belong to(so x/ydata is None), even though they are indeed within the axes theyactually belong to. This can occur when a widget is associated with an"inset_axes" that's actually outside the parent axes. A practical caseis given by```pythonfrom pylab import *ax = figure(layout="constrained").add_subplot()ax1 = ax.inset_axes([0, 1, 1, .25], sharex=ax)ss = mpl.widgets.SpanSelector(ax1, print, "horizontal")show() # try to trigger the spanselector```which would raise an exception prior to this patch.Improve the recomputation logic by fully reparenting the event passed tothe widget to the correct parent axes from the onset.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When axes are overlapping, LocationEvent.inaxes can point not to the axes we care about, but to another one. Widgets currently recompute location event axes coordinates relative to the axes to which the widget is assigned (#25555), but this recomputation code was previously brittle wrt. events that are outside the axes they wrongly believe they belong to (so x/ydata is None), even though they are indeed within the axes they actually belong to. This can occur when a widget is associated with an "inset_axes" that's actually outside the parent axes. A practical case is given by
which would raise an exception prior to this patch.
Improve the recomputation logic by fully reparenting the event passed to the widget to the correct parent axes from the onset.
PR summary
PR checklist