Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: restrict 'pygobject-ver' for Ubuntu 22.04 jobs#29847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

jayaddison
Copy link
Contributor

@jayaddisonjayaddison commentedApr 1, 2025
edited
Loading

PR summary

  • Why is this change necessary?

Unit test coverage for GTK (both v3 and v3) in our GitHub Actions CItests.yml workflow is largely skipped at the moment.

This is because recent versions ofPyGObject -- as required forimport gi to succeed -- are incompatible with thegirepository-1.0 system dependency that we install on our Ubuntu 22.04 runners.

Specifically, as noted in#29844,PyGObject v3.52 adds a requirement ongirepository-2.0.

The goal here is to re-enable GTK-related test coverage.

  • What problem does it solve?

To work around the problem, this pull request suggests pinning the upper-bound version of thePyGObject library that we install on the affected Ubuntu 22.04 runners.

  • What is the reasoning for this implementation?
  1. Thegirepository-2.0 system dependency is unavailable on Ubuntu 22.04 (jammy) and may not become available on that OS version.

  2. We have existing test coverage ofPyGObject v3.52 on Ubuntu 24.04withgirepository-2.0 - so my reasoning (also describedhere) is that retaining coverage ofgirepository-1.0 is worthwhile.

PR checklist

Resolves#29844.

Edit: attempt to clarify the nature of the problem that is being solved by this.
Edit: plurality fixup
Edit: rephrase description again.
Edit: clarify that this may not be a temporary fix (girepository-2.0 may not become available on Ubuntu 22.04).

@jayaddisonjayaddison changed the titleci: restrict 'pygobject-ver' for Ubuntu 20.04 jobsci: restrict 'pygobject-ver' for Ubuntu 22.04 jobsApr 1, 2025
@jayaddison

This comment was marked as resolved.

@jayaddisonjayaddison marked this pull request as draftApril 1, 2025 11:19
@jayaddison

This comment was marked as resolved.

@jayaddison

This comment was marked as outdated.

@jayaddisonjayaddison marked this pull request as ready for reviewApril 1, 2025 11:45
@jayaddisonjayaddisonforce-pushed theissue-29844/gha-ci-ubuntu-2204-pygobject-pypkg-pin branch from0216d73 toa76b888CompareApril 1, 2025 18:50
@jayaddisonjayaddisonforce-pushed theissue-29844/gha-ci-ubuntu-2204-pygobject-pypkg-pin branch froma76b888 to5b2001cCompareApril 23, 2025 17:21
@dstansby
Copy link
Member

Hmm, I've rerun the failing CI job to see if it passes. It doesn't seem to be failing onmain, so if it fails again it might be caused by this PR.

@jayaddison
Copy link
ContributorAuthor

Thanks@dstansby - possibly another flaky test case I can file a bug for? I hadn't encountered that particular failure mode before (test_determinism_check, if I remember correctly -- I should have added a note here, and am trying to track down the build logs again).

@jayaddison
Copy link
ContributorAuthor

Found it; the failure (caution: subsequently includes extremely lengthy diff) that occurred is:https://github.com/matplotlib/matplotlib/actions/runs/14624206559/job/41031666394#step:13:171

@jayaddison
Copy link
ContributorAuthor

Thanks@dstansby

@jayaddison
Copy link
ContributorAuthor

Is it OK if I merge-from-main and/or rebase-against-main? I think this PR remains equally valid against the latest changes -- I'd like to keep the test results relatively fresh.

@jayaddison
Copy link
ContributorAuthor

jayaddison commentedMay 7, 2025
edited
Loading

Is it OK if I merge-from-main and/or rebase-against-main? I think this PR remains equally valid against the latest changes -- I'd like to keep the test results relatively fresh.

I thinkrebasing is preferable, and CI results should be green(ish) onmain in a few moments, so I'll plan to do that soon.

Currently we continue to install `girepository-1.0` during theseworkflow jobs; `PyGObject` v3.52 needs `girepository-2.0` instead.
@jayaddisonjayaddisonforce-pushed theissue-29844/gha-ci-ubuntu-2204-pygobject-pypkg-pin branch from5b2001c toda2063bCompareMay 7, 2025 10:05
@jayaddison
Copy link
ContributorAuthor

Ping for any additional review / feedback?

@timhoffmtimhoffm added this to thev3.11.0 milestoneMay 12, 2025
@timhoffmtimhoffm added CI: testingCI configuration and testing GUI: gtk labelsMay 12, 2025
@timhoffmtimhoffm merged commit15787d5 intomatplotlib:mainMay 12, 2025
43 of 45 checks passed
@timhoffm
Copy link
Member

Thanks@jayaddison!

@jayaddison
Copy link
ContributorAuthor

You're welcome - thank you@timhoffm!

@jayaddisonjayaddison deleted the issue-29844/gha-ci-ubuntu-2204-pygobject-pypkg-pin branchMay 12, 2025 22:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
CI: testingCI configuration and testingGUI: gtk
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

[MNT]: CI: pygobject fails to install during ubuntu-22.04 GitHub Actions jobs
3 participants
@jayaddison@dstansby@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp