Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
ci: restrict 'pygobject-ver' for Ubuntu 22.04 jobs#29847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
ci: restrict 'pygobject-ver' for Ubuntu 22.04 jobs#29847
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
0216d73
toa76b888
Comparea76b888
to5b2001c
CompareHmm, I've rerun the failing CI job to see if it passes. It doesn't seem to be failing on |
Thanks@dstansby - possibly another flaky test case I can file a bug for? I hadn't encountered that particular failure mode before ( |
Found it; the failure (caution: subsequently includes extremely lengthy diff) that occurred is:https://github.com/matplotlib/matplotlib/actions/runs/14624206559/job/41031666394#step:13:171 |
Thanks@dstansby |
Is it OK if I merge-from-main and/or rebase-against-main? I think this PR remains equally valid against the latest changes -- I'd like to keep the test results relatively fresh. |
jayaddison commentedMay 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I thinkrebasing is preferable, and CI results should be green(ish) on |
Currently we continue to install `girepository-1.0` during theseworkflow jobs; `PyGObject` v3.52 needs `girepository-2.0` instead.
5b2001c
toda2063b
ComparePing for any additional review / feedback? |
15787d5
intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@jayaddison! |
You're welcome - thank you@timhoffm! |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Unit test coverage for GTK (both v3 and v3) in our GitHub Actions CI
tests.yml
workflow is largely skipped at the moment.This is because recent versions of
PyGObject
-- as required forimport gi
to succeed -- are incompatible with thegirepository-1.0
system dependency that we install on our Ubuntu 22.04 runners.Specifically, as noted in#29844,
PyGObject
v3.52 adds a requirement ongirepository-2.0
.The goal here is to re-enable GTK-related test coverage.
To work around the problem, this pull request suggests pinning the upper-bound version of the
PyGObject
library that we install on the affected Ubuntu 22.04 runners.The
girepository-2.0
system dependency is unavailable on Ubuntu 22.04 (jammy
) and may not become available on that OS version.We have existing test coverage of
PyGObject
v3.52 on Ubuntu 24.04withgirepository-2.0
- so my reasoning (also describedhere) is that retaining coverage ofgirepository-1.0
is worthwhile.PR checklist
Resolves#29844.
Edit: attempt to clarify the nature of the problem that is being solved by this.
Edit: plurality fixup
Edit: rephrase description again.
Edit: clarify that this may not be a temporary fix (
girepository-2.0
may not become available on Ubuntu 22.04).