Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Type annotation add_subplot for projection="3d"#29341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 5 commits intomatplotlib:mainfromstefanv:add_subplots-axes3d
May 2, 2025

Conversation

stefanv
Copy link
Contributor

This is a proof-of-concept PR to address#29334

Jeitan reacted with thumbs up emoji
@dstansby
Copy link
Member

This looks good to me at a glance - is there still interest in merging this? It's currently marked as draft.

timhoffm reacted with thumbs up emoji

@stefanvstefanv marked this pull request as ready for reviewApril 30, 2025 23:12
@stefanv
Copy link
ContributorAuthor

I'd still like to see this, or something like it, merged!

@stefanvstefanvforce-pushed theadd_subplots-axes3d branch from3b60169 to81f6ba3CompareMay 1, 2025 16:50
@@ -25,6 +25,9 @@ from matplotlib.lines import Line2D
from matplotlib.patches import Rectangle, Patch
from matplotlib.text import Text
from matplotlib.transforms import Affine2D, Bbox, BboxBase, Transform
if TYPE_CHECKING:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, this guard is not needed in .pyi files, because they are only used for tyoechecking.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, removed

@dstansbydstansby requested a review fromtimhoffmMay 2, 2025 18:01
@timhoffmtimhoffm merged commitabda9dd intomatplotlib:mainMay 2, 2025
40 checks passed
@stefanv
Copy link
ContributorAuthor

Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

6 participants
@stefanv@dstansby@QuLogic@timhoffm@tacaswell@scottshambaugh
[8]ページ先頭
©2009-2025 Movatter.jp