NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Adding figratio to matplotlib to allow dynamic change of figure size based upon width/height and aspect#29262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

arkapudota2003 wants to merge1 commit intomatplotlib:main

base:main

Choose a base branch

fromarkapudota2003:main

Open

Adding figratio to matplotlib to allow dynamic change of figure size based upon width/height and aspect#29262

arkapudota2003 wants to merge1 commit intomatplotlib:mainfromarkapudota2003:main

Conversation

Copy link

arkapudota2003 commentedDec 9, 2024

PR summary

PR checklist

[y] "closes #0000" is in the body of the PR description tolink the related issue
[y] new and changed code istested
[N/A]Plotting related features are demonstrated in anexample
[N/A]New Features andAPI Changes are noted with adirective and release note
[y] Documentation complies withgeneral anddocstring guidelines

Adding figratio to matplotlib

211fc14

github-actionsbot added the topic: figures and subfigures label

Dec 9, 2024

github-actionsbot reviewed

Dec 9, 2024

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link

Member

timhoffm commentedDec 9, 2024

Thanks for your willingness to contribute. I assume this should address#28758? - Please always link the related issues, as stated in the PR checklist.

The PR does not refect the state of the discussion in#28758. All we agreed upon so far was to acceptNone as component in the tuple given to thefigsize keyword argument, with the meaning: Take that component fromrcParams["figure.figsize"]; i.e.plt.figure(figsize=(None, 3) andplt.figure(figsize=(3, None)