Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Raise warning if both c and facecolors are used in scatter plot (... and related improvements in the test suite).#29130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
21 commits Select commitHold shift + click to select a range
5a26bb9 Raise warning if both c and facecolors are used in scatter plot. In t…
NGWif1966c2 Corrected flake8 formatting warnings.
NGWi53a0825 Removed offending whitespace and extra line.
NGWia777a15 Merge branch 'issue24404_addwarning' of https://github.com/NGWi/matpl…
NGWi8031809 Corrected old test that qualified for the new warning.
NGWi8ae213c Made message more concise, and straightened old test, to fulfill @tim…
NGWi49f03f7 Added test.
NGWi8234066 Corrected flake8 linting objections.
NGWi38c092a Added direct test of _parse method to attempt to make Codecov happy.
NGWie6e49aa Added pragma tags for code coverage to ignore unused but untested sim…
NGWi39e1899 Raise warning if both c and facecolors are used in scatter plot. In t…
NGWi06c8a76 Corrected flake8 formatting warnings.
NGWi72138c6 Corrected old test that qualified for the new warning.
NGWi319b92b Made message more concise, and straightened old test, to fulfill @tim…
NGWie348dfc Added test.
NGWifcf6ce2 Corrected flake8 linting objections.
NGWi9601975 Added direct test of _parse method to attempt to make Codecov happy.
NGWia18364c Added pragma tags for code coverage to ignore unused but untested sim…
NGWi310a15f Corrected placement of pragma tags and added 'currently unused' to Je…
NGWi7c01a7b Tim's suggestion for naming test's list of colors.
NGWifd3d9db Corrected call to changed variable name.
NGWiFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Corrected old test that qualified for the new warning.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit72138c6ce0f45b053e54eea8ff89e2e0983c780a
There are no files selected for viewing
1 change: 0 additions & 1 deletionlib/matplotlib/tests/test_legend.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -974,7 +974,6 @@ def test_legend_pathcollection_labelcolor_markfacecolor_cmap(): | ||
| np.arange(10), | ||
| np.arange(10), | ||
| label='#1', | ||
rcomer marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| facecolor=facecolors | ||
| ) | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.