Mar 31, 2025 · Jan 3, 2025 · Jan 3, 2025 · Jan 8, 2025 · Jan 20, 2025 · Jan 27, 2025
diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py
                    self._antialiaseds, self._urls,
                    "screen", self.get_hatchcolor()
                )
            except TypeError:
                hatchcolors_arg_supported = False

            if self._gapcolor is not None:
                # First draw paths within the gaps.
                ipaths, ilinestyles = self._get_inverse_paths_linestyles()
                args = [gc, transform.frozen(), ipaths, self.get_transforms(),
                        offsets, offset_trf, [mcolors.to_rgba("none")],
                        self._gapcolor, self._linewidths, ilinestyles,
                        self._antialiaseds, self._urls, "screen"]
                if hatchcolors_arg_supported:
                    args.append(self.get_hatchcolor())
                args = [offsets, offset_trf, [mcolors.to_rgba("none")], self._gapcolor,
                        self._linewidths, ilinestyles, self._antialiaseds, self._urls,
                        "screen", self.get_hatchcolor()]

                renderer.draw_path_collection(*args)
                if hatchcolors_arg_supported:
                    renderer.draw_path_collection(gc, transform.frozen(), ipaths,
                                                  self.get_transforms(), *args)
                else:
                    # If the renderer does not support the hatchcolors argument,
                    # iterate over the paths and draw them one by one.
                    path_ids = renderer._iter_collection_raw_paths(
                        transform.frozen(), ipaths, self.get_transforms())
                    for xo, yo, path_id, gc0, rgbFace in renderer._iter_collection(
                        gc, list(path_ids), *args
                    ):
                        path, transform = path_id
                        if xo != 0 or yo != 0:
                            transform = transform.frozen()
                            transform.translate(xo, yo)
                        renderer.draw_path(gc0, path, transform, rgbFace)

            args = [offsets, offset_trf, self.get_facecolor(), self.get_edgecolor(),
                    self._linewidths, self._linestyles, self._antialiaseds, self._urls,
                    "screen", self.get_hatchcolor()]

            args = [gc, transform.frozen(), paths, self.get_transforms(),
                    offsets, offset_trf, self.get_facecolor(),
                    self.get_edgecolor(), self._linewidths, self._linestyles,
                    self._antialiaseds, self._urls, "screen"]
            if hatchcolors_arg_supported:
                args.append(self.get_hatchcolor())

            renderer.draw_path_collection(*args)
                renderer.draw_path_collection(gc, transform.frozen(), paths,
                                              self.get_transforms(), *args)
            else:
                path_ids = renderer._iter_collection_raw_paths(
                    transform.frozen(), paths, self.get_transforms())
                for xo, yo, path_id, gc0, rgbFace in renderer._iter_collection(
                    gc, list(path_ids), *args
                ):
                    path, transform = path_id
                    if xo != 0 or yo != 0:
                        transform = transform.frozen()
                        transform.translate(xo, yo)
                    renderer.draw_path(gc0, path, transform, rgbFace)

        gc.restore()
        renderer.close_group(self.__class__.__name__)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -431,29 +431,51 @@
		self._antialiaseds, self._urls,
		"screen", self.get_hatchcolor()
		)
		except TypeError:
Copy link Member dstansbyMar 21, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This seems to me like a pretty brittle way of checking if`draw_path_collection` has a`hatchcolors` argument (ie. it could fail for other cases than just`hatchcolors` isn't present). Instead, could youinspect the signature of`renderer.draw_path_collection` to definitively decide whether to pass hatchcolors or not? Copy link Contributor r3ksteMar 22, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. As explained by anntzer in thiscomment, matplotlib has not required the signature of third-party draw_path_collection implementations to be introspectable e.g. with inspect.signature Copy link Member timhoffmMar 24, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It's worth explicitly documenting this in the comment, see suggestion above. r3kste reacted with thumbs up emoji
		hatchcolors_arg_supported = False
Check warning on line 435 in lib/matplotlib/collections.py View check run for this annotation Codecov/ codecov/patch lib/matplotlib/collections.py#L434-L435 `Added lines #L434 - L435 were not covered by tests`
Copy link Member dstansbyMar 21, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. `codecov` is saying that these lines aren't covered (and several other lines in this file). Could you add some tests for these lines? They don't have to be figure tests, they can just test that the code works without erroring. Copy link Contributor r3ksteMar 22, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. These lines are run only in the case of a third-party backend. However, I am not sure how to test this within the current testing framework of matplotlib, without a third-party backend. Copy link Member story645Mar 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. You can make a mock third party backend to call the function - there are some examples of other mocks in the tests r3kste reacted with thumbs up emoji

		if self._gapcolor is not None:
		# First draw paths within the gaps.
		ipaths, ilinestyles = self._get_inverse_paths_linestyles()
		args = [gc, transform.frozen(), ipaths, self.get_transforms(),
		offsets, offset_trf, [mcolors.to_rgba("none")],
		self._gapcolor, self._linewidths, ilinestyles,
		self._antialiaseds, self._urls, "screen"]
		if hatchcolors_arg_supported:
		args.append(self.get_hatchcolor())
		args = [offsets, offset_trf, [mcolors.to_rgba("none")], self._gapcolor,
		self._linewidths, ilinestyles, self._antialiaseds, self._urls,
		"screen", self.get_hatchcolor()]

		renderer.draw_path_collection(*args)
		if hatchcolors_arg_supported:
		renderer.draw_path_collection(gc, transform.frozen(), ipaths,
		self.get_transforms(), *args)
		else:
		# If the renderer does not support the hatchcolors argument,
		# iterate over the paths and draw them one by one.
		path_ids = renderer._iter_collection_raw_paths(
Check warning on line 450 in lib/matplotlib/collections.py View check run for this annotation Codecov/ codecov/patch lib/matplotlib/collections.py#L450 `Added line #L450 was not covered by tests`
		transform.frozen(), ipaths, self.get_transforms())
		for xo, yo, path_id, gc0, rgbFace in renderer._iter_collection(
		gc, list(path_ids), *args
		):
		path, transform = path_id
Check warning on line 455 in lib/matplotlib/collections.py View check run for this annotation Codecov/ codecov/patch lib/matplotlib/collections.py#L455 `Added line #L455 was not covered by tests`
		if xo != 0 or yo != 0:
		transform = transform.frozen()
		transform.translate(xo, yo)
		renderer.draw_path(gc0, path, transform, rgbFace)
Check warning on line 459 in lib/matplotlib/collections.py View check run for this annotation Codecov/ codecov/patch lib/matplotlib/collections.py#L457-L459 `Added lines #L457 - L459 were not covered by tests`

		args = [offsets, offset_trf, self.get_facecolor(), self.get_edgecolor(),
		self._linewidths, self._linestyles, self._antialiaseds, self._urls,
		"screen", self.get_hatchcolor()]

		args = [gc, transform.frozen(), paths, self.get_transforms(),
		offsets, offset_trf, self.get_facecolor(),
		self.get_edgecolor(), self._linewidths, self._linestyles,
		self._antialiaseds, self._urls, "screen"]
		if hatchcolors_arg_supported:
		args.append(self.get_hatchcolor())

		renderer.draw_path_collection(*args)
		renderer.draw_path_collection(gc, transform.frozen(), paths,
		self.get_transforms(), *args)
		else:
		path_ids = renderer._iter_collection_raw_paths(
Check warning on line 469 in lib/matplotlib/collections.py View check run for this annotation Codecov/ codecov/patch lib/matplotlib/collections.py#L469 `Added line #L469 was not covered by tests`
		transform.frozen(), paths, self.get_transforms())
		for xo, yo, path_id, gc0, rgbFace in renderer._iter_collection(
		gc, list(path_ids), *args
		):
		path, transform = path_id
Check warning on line 474 in lib/matplotlib/collections.py View check run for this annotation Codecov/ codecov/patch lib/matplotlib/collections.py#L474 `Added line #L474 was not covered by tests`
		if xo != 0 or yo != 0:
		transform = transform.frozen()
		transform.translate(xo, yo)
		renderer.draw_path(gc0, path, transform, rgbFace)
Check warning on line 478 in lib/matplotlib/collections.py View check run for this annotation Codecov/ codecov/patch lib/matplotlib/collections.py#L476-L478 `Added lines #L476 - L478 were not covered by tests`

		gc.restore()
		renderer.close_group(self.__class__.__name__)
Expand Down