NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

closes #24617. adds figsize alias and fixed #25091 subplot param getter#28936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

EthanAGit wants to merge3 commits intomatplotlib:main

base:main

Choose a base branch

fromEthanAGit:main

Open

closes #24617. adds figsize alias and fixed #25091 subplot param getter#28936

EthanAGit wants to merge3 commits intomatplotlib:mainfromEthanAGit:main

Conversation

Copy link

EthanAGit commentedOct 3, 2024

First open source contribution. I saw#25901 and noticed that he was in the wrong scope for his subplot getter to be returning the appropriate params, so I set one up in the correct class and gave the figure class a return all subfigure's subplot getter. Also added alias for size_inches -> figsize

[✔️ ] "closes#24617 is in the body of the PR description tolink the related issue
[✔️ ] new and changed code istested
[N/A] Plotting related features are demonstrated in anexample
[ N/A] New Features and API Changes are noted with adirective and release note
[ ✔️] Documentation complies withgeneral anddocstring guidelines

EthanAGit added3 commits

October 3, 2024 07:07

issuematplotlib#24617fixed getter frommatplotlib#2509

6b63303

This is my first open source contribution. I don't know how the setter works as I used someone else's working one, but I did get the getter to pass it's test. Added a figsize alias as well.

Update figure.py

3ebf291

update

f79e9c5

github-actionsbot added the topic: figures and subfigures label

Oct 3, 2024

Copy link

Member

timhoffm commentedOct 7, 2024

Thanks for the contribution. We're quite busy getting the 3.10 release out. We'll have a look later.

Copy link

Member

QuLogic commentedOct 15, 2024

Without having looked too much into details, at the least, this should pass tests and linting.

Copy link

Thanushri16 commentedNov 8, 2024

Is this issue closed? Can I start working on it? I'm a new contributor and I have some ideas but will get in touch if I have any questions if the issue is still open.