Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: clarify alpha handling for indicate_inset[_zoom]#28710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import functools | ||
import itertools | ||
import logging | ||
@@ -452,8 +452,10 @@ | ||
edgecolor : :mpltype:`color`, default: '0.5' | ||
Color of the rectangle and color of the connecting lines. | ||
alpha : float or None, default: 0.5 | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. we should maybe change the default? The use case for alpha taking precedence was user passed in alpha trumping color tuple alpha.#24691 (comment) Uh@timhoffm? (wrote this before I saw Tim's comment 😓 ) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Agree that this is not ideal, because you cannot set face and edge transparencies independently without first resetting alpha. In general, this seems not too useful by default: I would have expected the edgecolors to be solid (=frame should be above the plot). There is no facecolor by default. The only thing this serves is that you can get a semi-transparent face by specifying a simple solid color - OTOH that's confusing. I suggest to change this to Overall I'd just do it and call it a bug fix. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. alpha = 0.5 was originally for the lines that indicate the inset which often cross data, and hence its nice to have some indication of the data underneath. It was not meant to apply to the facecolor of the inset indicator patch. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. The current defaults make sense to me. The point of these patches is to point to some other features we areindicating, so they should interfere as little as possible with our view of those things. I think most of the time a user would not want a facecolor because that would make it harder to see the colours of the thing they areindicating. With this PR we will have documented how to change the alpha for the rarer occasions when a facecolor is wanted and the face/edge alpha should be different. Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Thanks@rcomer, was thinking of it in very general artists terms and not the specific use case 🤦♀️ | ||
Transparency of the rectangle and connector lines. If not | ||
``None``, this overrides any alpha value included in the | ||
*facecolor* and *edgecolor* parameters. | ||
zorder : float, default: 4.99 | ||
Drawing order of the rectangle and connector lines. The default, | ||
Uh oh!
There was an error while loading.Please reload this page.