Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: Made AffineDeltaTransform pass-through properly#28375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fad4ead to58379e3Compare@anntzer Could you take a look at this please? |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Before this change, transform sub-graphs with ``AffineDeltaTransform`` did not update correctly. | ||
| This PR ensures that changes to axis limits are passed through correctly to the underlying transform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Wording is not really optimal (considering that this will be part of a changelog). Also the reference to axes limits may be a bit too specific (AffineDeltaTransform does not refer to transData/transLimits in itself).
Also this isn't really an API change, but rather a bugfix (so it may belong more to the whatsnew folder?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My lens on this was a bit hyper-specific. I am happy to go with any suggestion you may have on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
At the very least, it's "when the child transform changes", not specifically axis limits (as that's only the case for the example in#28364.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@QuLogic Thanks for the suggestion. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Changelog could be improved, but I believe the fix is correct.
58379e3 to0b91d8eCompare3a0bc88 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Makes
mtrans.AffineDeltaTransformupdate correctly when axis bounds change. Change made by@anntzercloses#28372
enables the proposed example in#28364 to work correctly
Testing
A combination of manual and unit tests.
Manually verified that the example above works as expected now:
Before:
After:
Unit test shows that the parent transform is invalidated when the child is now.
PR checklist