Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for horizontal CheckButtons#27946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
QuLogic wants to merge2 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromQuLogic:horizontal-checkbuttons

Conversation

QuLogic
Copy link
Member

PR summary

This is a followup to#13374, but forCheckButtons. Also updates the test image to check both options.

Feel free to review after#13374 or as a group. This is built on top of that one, so merging this would merge that as well.

PR checklist

@QuLogicQuLogicforce-pushed thehorizontal-checkbuttons branch fromb58dc7d tof92a95fCompareMarch 19, 2024 06:00
@QuLogicQuLogicforce-pushed thehorizontal-checkbuttons branch fromf92a95f to873a3d8CompareMay 17, 2024 20:24
@QuLogicQuLogic added this to thev3.10.0 milestoneMay 17, 2024
@timhoffm
Copy link
Member

As a general remark: The buttons are placed above the text:
grafik

I believe the more common placement text next to the buttons:
grafik
This would also have the advantage of keeping the height smaller.

I'm not blocking, but we should be clear what the desired result is and we're not accidentally moving into an unwanted direction.

@QuLogicQuLogic mentioned this pull requestAug 21, 2024
6 tasks
A new optional keyword argument 'layout_direction' is introduced tocontrol it. The new parameter defaults to 'vertical' for backwardscompatibility.
@QuLogic
Copy link
MemberAuthor

I assume the reason for implementing it that way was that it was easier to implement. The latter requires accounting for the text width before placing the markers, while the former just places them equidistantly.

@QuLogicQuLogicforce-pushed thehorizontal-checkbuttons branch from873a3d8 to9a5eb5bCompareAugust 21, 2024 22:07
@timhoffm
Copy link
Member

You could still place equidistantly with text right of the buttons. The possible overlap issues are the same, except that you have a constant reserved space for the buttons.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@timhoffm@ksunden@mromanie

[8]ページ先頭

©2009-2025 Movatter.jp