Note that the inheritedCollection.set_offset andCollection.get_offset methods with 2D coordinates are used in zordering calculations and I couldn't see an easy way to abstract those out in order to override those methods and keep the same names as the 2D case.

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
[n/a]New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

scottshambaugh force-pushed theset_offsets_3d branch frombbd244b toa6c2facCompare

December 21, 2023 22:01

scottshambaugh added the topic: mplot3d label

Dec 21, 2023

Copy link

ContributorAuthor

scottshambaugh commentedJan 11, 2024•
edited
Loading

Only test failure is codecov, but these are fairly well covered and should be fine.

scottshambaugh added this to thev3.9.0 milestone

Mar 1, 2024

timhoffm reviewed

Mar 10, 2024

View reviewed changes

Copy link

Member

timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor style fixes / improvements.

lib/mpl_toolkits/mplot3d/art3d.py OutdatedShow resolvedHide resolved

timhoffm reviewed

Mar 10, 2024

View reviewed changes

lib/mpl_toolkits/mplot3d/art3d.py OutdatedShow resolvedHide resolved

Copy link

Member

timhoffm commentedMar 10, 2024

I took the liberty to create a commit with the style fixes.

timhoffm force-pushed theset_offsets_3d branch from8f94462 tod2b39ddCompare

March 10, 2024 20:38

timhoffm reviewed

Mar 10, 2024

View reviewed changes

lib/mpl_toolkits/mplot3d/art3d.pyShow resolvedHide resolved

lib/mpl_toolkits/mplot3d/art3d.py OutdatedShow resolvedHide resolved

scottshambaughand others added5 commits

March 11, 2024 19:59

get_offsets3d and set_offsets3d

02a94c9

Whats new

89e2b7f

Style fixes / improvements

c6c01ff

Apply suggestions from code review

432d0c4

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Code review modifications

54bd200

scottshambaugh force-pushed theset_offsets_3d branch from070dfab to54bd200Compare

March 11, 2024 19:59

scottshambaugh added3 commits

March 11, 2024 14:51

Fix docs typos

ef29b4a

Fix docs build?

e13bbbe

Fix docs build?

e2b6454

Copy link

Member

timhoffm commentedMar 11, 2024•
edited
Loading

Could you add a simple test? I think just manipulating the values and reading them back to assert that you get the new offesets is sufficient. Or, if you want to be a bit more fancy make an image comparison test where you create a collection infig_test withoffests_0 and thenset_offsets3d(offsets_1) and compare that tofig_ref with directly setoffsets_1. This could also be amended withzdir.