Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[TYP] Change typing for texts to StrLike#26867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
timhoffm commentedSep 22, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
One can see this as similar to %s or f-strings, where the parameter is implicitly converted to str. OTOH I'm reluctant to officially broaden the type to Any. This would be very general, and IHMO would loose the semantic aspect of the type definition. Therefore, at least for the docstrings, I'm very much in favor of keeping |
bf29a74
toafbdb8f
Compare
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Related to#26858.
It is a bit unintuitive (maybe) to change like this, but apparently people are relying on
set_text
making thestr
-conversion.Setting as draft for now as we probably should discuss it (and I have most likely missed some).
Additional classes/methods to change:
PR checklist