Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Improve RectangleSelector Rotation revisited and rebased#26833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
dhomeier wants to merge9 commits intomatplotlib:mainChoose a base branch fromdhomeier:selector-rotation
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+521 −309
Open
Changes from1 commit
Commits
Show all changes
9 commits Select commitHold shift + click to select a range
8063e15
Add edge midpoint helper methods
dhomeier728a749
Use assert_allclose in RectangleSelector tests
dhomeier23e3bc0
Use display coordinates for RectangleSelector, update handles on resize
dhomeier78d0f02
Rectangle resize tests with multiple start/end corners
dhomeier5ba3b5f
Fix deprecation warnings from `self.visible` and `set_data(x, y)`
dhomeierb7f12ab
Fix case where axis limits are reversed
astrofrogc3b7e4b
Corrections to comments
dhomeierfc74f95
Fix ellipse patch bbox edges and add selector tests
dhomeier27c1c11
Let @rotation.setter rotate around center, too; update selector tests
dhomeierFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Fix deprecation warnings from
self.visible
andset_data(x, y)
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit5ba3b5fe8bb048d104932fdbdba497aba4ff963a
There are no files selected for viewing
6 changes: 3 additions & 3 deletionslib/matplotlib/widgets.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.