Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[GSoD] refine gallery examples (titles, scope, link)#26456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
esibinga wants to merge2 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromesibinga:link-to-user-guide

Conversation

esibinga
Copy link
Collaborator

PR summary

small cleanup projects:

  • add link to axes intro in user guide
  • remove text that doesn't belong in gallery example
  • add descriptive titles to dolphins, donuts, and firefox

@story645

PR checklist

- add link to axes intro in user guide- remove text that doesn't belong in gallery example- add descriptive titles to dolphins, donuts, and firefox
@story645story645 added the Documentation: examplesfiles in galleries/examples labelAug 4, 2023
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@@ -4,6 +4,8 @@
===================

This figure shows the name of several matplotlib elements composing a figure

To see detailed information, see :ref:`axes_intro`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

From the docs build

/home/circleci/project/doc/gallery/showcase/anatomy.rst:30: WARNING: undefined label: 'axes_intro'

@story645story645 self-assigned thisAug 24, 2023
@@ -4,6 +4,8 @@
===================

This figure shows the name of several matplotlib elements composing a figure

To see detailed information, see :ref:`axes_intro`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Toseedetailedinformation,see :ref:`axes_intro`.
Toseedetailedinformation,see :doc:`axes_intro`.

axes_intro doesn't have a label - probably should but that's a separate issue.https://github.com/matplotlib/matplotlib/blob/main/galleries/users_explain/axes/axes_intro.rst?plain=1

@story645
Copy link
Member

Hey@esibinga sorry this got stalled out, do you have bandwidth to finish?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 left review comments

@jklymakjklymakjklymak left review comments

@timhoffmtimhoffmtimhoffm left review comments

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@story645story645

Labels
Documentation: examplesfiles in galleries/examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@esibinga@story645@jklymak@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp