Mar 28, 2023 · Mar 30, 2023 · Mar 30, 2023 · Mar 30, 2023 · Mar 30, 2023 · Mar 31, 2023
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
        # groupers to keep track of x, y and title labels we want to align.
        # see self.align_xlabels, self.align_ylabels, self.align_titles and
        # axis._get_tick_boxes_siblings
        self._align_label_groups = {"x": cbook.Grouper(), "y": cbook.Grouper(), "title": cbook.Grouper()}
        self._align_label_groups = {"x": cbook.Grouper(), "y": cbook.Grouper()
            , "title": cbook.Grouper()}

        self.figure = self
        self._localaxes = []  # track all axes
diff --git a/lib/matplotlib/tests/test_figure.py b/lib/matplotlib/tests/test_figure.py
    np.testing.assert_allclose(xn[:2], xn[2:])
    np.testing.assert_allclose(yn[::2], yn[1::2])


 ## TODO add image comparison
 def test_align_titles():
    fig, axs = plt.subplots(2, 2,
    axs[0][1].set_title('Title2', loc="left")
    fig.align_titles()
    fig.savefig("./result_images/test_figure/figure_align_titles")
    compare_images("./lib/matplotlib/tests/baseline_images/figure_align_titles.png", "./result_images/test_figure/figure_align_titles.png", 0)
    compare_images("./lib/matplotlib/tests/baseline_images/figure_align_titles.png",
                   "./result_images/test_figure/figure_align_titles.png", 0)


 ## TODO add image comparison
 @image_comparison(['figure_align_titles_param'], extensions=['png', 'svg'],
Original file line number	Diff line number	Diff line change
Expand Up		@@ -186,7 +186,8 @@ def __init__(self, **kwargs):
		# groupers to keep track of x, y and title labels we want to align.
		# see self.align_xlabels, self.align_ylabels, self.align_titles and
		# axis._get_tick_boxes_siblings
		self._align_label_groups = {"x": cbook.Grouper(), "y": cbook.Grouper(), "title": cbook.Grouper()}
		self._align_label_groups = {"x": cbook.Grouper(), "y": cbook.Grouper()
		, "title": cbook.Grouper()}

		self.figure = self
		self._localaxes = [] # track all axes
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -102,6 +102,7 @@ def test_align_labels_stray_axes():
		np.testing.assert_allclose(xn[:2], xn[2:])
		np.testing.assert_allclose(yn[::2], yn[1::2])


		## TODO add image comparison
		def test_align_titles():
		fig, axs = plt.subplots(2, 2,
Expand All		@@ -115,7 +116,9 @@ def test_align_titles():
		axs[0][1].set_title('Title2', loc="left")
		fig.align_titles()
		fig.savefig("./result_images/test_figure/figure_align_titles")
		compare_images("./lib/matplotlib/tests/baseline_images/figure_align_titles.png", "./result_images/test_figure/figure_align_titles.png", 0)
		compare_images("./lib/matplotlib/tests/baseline_images/figure_align_titles.png",
Copy link Member ksundenApr 4, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think we need to not use relative paths for this test
		"./result_images/test_figure/figure_align_titles.png", 0)


		## TODO add image comparison
		@image_comparison(['figure_align_titles_param'], extensions=['png', 'svg'],
Copy link Member ksundenApr 4, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. The test failures that are directly related to this PR are due to the baseline images for this image comparison not being added to the repo If it is passing locally, those two files (png, svg) should be added in the`baseline_images` folder
Expand Down