NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Fix hatch linewidth in PGF#24263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

oscargus wants to merge1 commit intomatplotlib:main

base:main

Choose a base branch

fromoscargus:pgfhatchlinewidth

Open

Fix hatch linewidth in PGF#24263

oscargus wants to merge1 commit intomatplotlib:mainfromoscargus:pgfhatchlinewidth

+24 −10

Conversation

Copy link

Member

oscargus commentedOct 24, 2022

Co-authored-by: Antony Leeanntzer.lee@gmail.com

PR Summary

Closes#15491

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

New features are documented, with examples if plot related.
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

oscargus added the backend: pgf label

Oct 24, 2022

oscargus marked this pull request as ready for review

October 24, 2022 16:05

Copy link

MemberAuthor

oscargus commentedOct 24, 2022

Not obvious why this kills all Linux tests, but no Windows or Mac tests.

oscargus force-pushed thepgfhatchlinewidth branch from2acf945 to7cbcd44Compare

October 29, 2022 10:42

Copy link

MemberAuthor

oscargus commentedOct 29, 2022

This looks extremely fragile. After a rebase I get even more errors... Especially, it seems like the conversion from PDF to PNG is affected for some unknown reason.

An example:

Screenshot of expected PDF

Screenshot of resulting PDF

These look quite the same IMHO.

PNG of expected PDF

PNG of resulting PDF

Expected PNG for reference

Copy link

MemberAuthor

oscargus commentedNov 3, 2022

I cannot run the whole test suite locally in one go as I get aFatal Python error: Illegal instruction every now and then. Most tests that fails here pass locally though (some minor, single pixel type of errors).

However, I noted this error from the test log:

! Package geometry Error: \paperheight (0.72229pt) too short.See the geometry package documentation for explanation.Type  H <return>  for immediate help. ...                                                                                                l.1006 \Gm@process                  No pages of output.Transcript written on figure.log.and the following error:

So it may indeed be related to what was discussed during the dev call: something messes up the ghostscript conversion process that propagates among the tests.

oscargus marked this pull request as draft

November 3, 2022 21:55

Copy link

Member

tacaswell commentedNov 3, 2022

Fatal Python error: Illegal instruction

Those tend to come from binaries compiled with CPU instruction sets that your CPU does not have...and I have mostly seen them with mkl or other "go fast" numpy extensionss....

oscargus force-pushed thepgfhatchlinewidth branch 3 times, most recently from1c7cd9f to4b2dc96Compare

November 6, 2022 11:23

github-actionsbot added the status: needs rebase label

Jan 27, 2023

oscargus mentioned this pull request

Jan 24, 2025

Fill hatch in PDF backend#29392

Merged

2 tasks

Copy link

Member

story645 commentedMay 16, 2025

Hi@oscargus any plans to finish this up? Particularly so that#29392 can get rebased on it?

Copy link

MemberAuthor

oscargus commentedMay 16, 2025

I'd be happy to finish it. Just that I do not really know what remains to be done and/or what causes the weird inconsistent test images.

But I'll try to rebase it and see what the current status is and if anything has changed.

oscargus force-pushed thepgfhatchlinewidth branch from4b2dc96 tob218519Compare

May 16, 2025 19:43

github-actionsbot removed the status: needs rebase label

May 16, 2025

oscargus force-pushed thepgfhatchlinewidth branch fromb218519 to6b8c2fdCompare

May 16, 2025 19:49

QuLogic reviewed

Jun 4, 2025

View reviewed changes

lib/matplotlib/tests/test_backend_pgf.py OutdatedShow resolvedHide resolved

lib/matplotlib/tests/test_backend_pgf.py

		@pytest.mark.backend('pgf')
		@image_comparison(['hatch_linewidth'], extensions=['pdf'])
		def test_pgf_hatch_linewidth():
		mpl.backend_bases.register_backend('pdf', FigureCanvasPgf)

Copy link

Member

QuLogicJun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Considering how many things are failing, this must be a global setting that isn't reset.

Copy link

MemberAuthor

oscargusJun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ahh, good observation! That is indeed a good first thing to fix. I'll give it a try.

Copy link

MemberAuthor

oscargusJun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure this works as expected (cannot run matplotlib from source locally for unknown reasons).

Main problem was how to change the backend back after the test. One may consider adding an argument to theimage_comparison decorator that takes a lambda and evaluates it after the comparison is done.

I also considered usingcheck_figure_equal and mocking two classes that has a save_fig method that sets backend, but didn't understand how to deal with theclose call later on.

Copy link

Member

QuLogicJun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking at it again, the tests in this file usepytest.mark.backend('pgf') withimage_comparison(['foo.pdf']); do we really need the extra registration or are the other tests not working as expected?

oscargus force-pushed thepgfhatchlinewidth branch 4 times, most recently from3fa3d67 tod631b01Compare

June 4, 2025 09:00

Copy link

MemberAuthor

oscargus commentedJun 4, 2025

I think the test is correct now.

Added a try-except block to make sure that the backend is always restored.

oscargus force-pushed thepgfhatchlinewidth branch fromd631b01 to04232abCompare

June 4, 2025 09:22

oscargus marked this pull request as ready for review

June 4, 2025 10:04

QuLogic reviewed

Jun 4, 2025

View reviewed changes

lib/matplotlib/tests/test_backend_pgf.py OutdatedShow resolvedHide resolved

lib/matplotlib/backends/backend_pgf.py OutdatedShow resolvedHide resolved

oscargus force-pushed thepgfhatchlinewidth branch from04232ab to44a728cCompare

June 5, 2025 07:51

QuLogic reviewed

Jun 5, 2025

View reviewed changes

lib/matplotlib/backends/backend_pgf.py OutdatedShow resolvedHide resolved

Fix hatch linewidth in PGF

1d44eab

Co-authored-by: Antony Lee <anntzer.lee@gmail.com>

oscargus force-pushed thepgfhatchlinewidth branch from44a728c to1d44eabCompare

June 5, 2025 09:21

Labels

backend: pgf

4 participants

Movatterモバイル変換

Uh oh!

Fix hatch linewidth in PGF#24263

Are you sure you want to change the base?

Fix hatch linewidth in PGF#24263

Conversation

oscargus commentedOct 24, 2022

PR Summary

PR Checklist

Uh oh!

oscargus commentedOct 24, 2022

Uh oh!

oscargus commentedOct 29, 2022

Uh oh!

oscargus commentedNov 3, 2022

Uh oh!

tacaswell commentedNov 3, 2022

Uh oh!

story645 commentedMay 16, 2025

Uh oh!

oscargus commentedMay 16, 2025

Uh oh!

Uh oh!

QuLogicJun 4, 2025

Choose a reason for hiding this comment

Uh oh!

oscargusJun 4, 2025

Choose a reason for hiding this comment

Uh oh!

oscargusJun 4, 2025

Choose a reason for hiding this comment

Uh oh!

QuLogicJun 5, 2025

Choose a reason for hiding this comment

Uh oh!

oscargus commentedJun 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!