NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Forward select Rectangle kwargs to Connection patch#24082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ejmercier wants to merge3 commits intomatplotlib:mainfromejmercier:edgecolor-connector-bug

Closed

Forward select Rectangle kwargs to Connection patch#24082

ejmercier wants to merge3 commits intomatplotlib:mainfromejmercier:edgecolor-connector-bug

Conversation

Copy link

ejmercier commentedOct 3, 2022•
edited
Loading

PR Summary

Closes#23424
This bug fix forwards**kwargs from the indicate_inset function into theConnection Patch. It uses a blacklist to decide which ones should be passed aspatch_kwargs to theConnection Patch and not theRectangle patch.

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

[N/A ] New features are documented, with examples if plot related.
[N/A ] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
[N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
[N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Forwarded select Rectangle kwargs to the Conneciton patch

6a67b8e

ejmercier force-pushed theedgecolor-connector-bug branch fromc31fc6f to6a67b8eCompare

October 3, 2022 01:34

ejmercier changed the title~~Forwarded select Rectangle kwargs to the Conneciton patch~~Forwarded select Rectangle kwargs to the Connection patch

Oct 3, 2022

oscargus added the status: needs tests label

Oct 3, 2022

Copy link

Member

oscargus commentedOct 3, 2022

Thanks! Can you please add a test?

I think a suitable test is to set some of the parameters and then check that the resulting ConnectorPatch have the expected values.

Copy link

Author

ejmercier commentedOct 3, 2022

Yes I can add a test. Is there a specific place where I should create it?

Copy link

Member

oscargus commentedOct 4, 2022

I think thattest_axes.py would be a good place.https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/tests/test_axes.py

QuLogic reviewed

Oct 13, 2022

View reviewed changes

lib/matplotlib/axes/_axes.py OutdatedShow resolvedHide resolved

oscargus changed the title~~Forwarded select Rectangle kwargs to the Connection patch~~Forward select Rectangle kwargs to Connection patch

Oct 13, 2022

ejmercierand others added2 commits

October 15, 2022 15:33

Update lib/matplotlib/axes/_axes.py

d3328b0

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

Update lib/matplotlib/axes/_axes.py

8137712

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

timhoffm mentioned this pull request

Oct 31, 2022

[ENH]: Set connector line properties directly from indicate_inset#24317

Closed

Copy link

Member

rcomer commentedJan 30, 2023

Hi@ejmercier are you still interested in working on this one? It looks like it still needs a test.

I'm going to mark this as "draft" for now. Please mark it as "ready for review" when you are ready. In the meantime, if you need help, feel free to ask questions here. Or you may prefer to ask them in ourincubator gitter room.

rcomer marked this pull request as draft

January 30, 2023 19:28

Copy link

Author

ejmercier commentedJan 30, 2023

@rcomer thanks for checking up! I'm still looking to work on this. I'll plan to write the test soon and move it out of drafts! If I have any questions I'll reach out