Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

In usetex, remove vertical space inserted by TeX after displaymath.#24011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
anntzer wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromanntzer:dm

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedSep 26, 2022
edited
Loading

PR Summary

Closes#23977. One can also check with the simpler example given at#23977 (comment).

Actually in the specific case of the eqnarray given in#23977 there would still seem to be an extra blank line at the bottom, but this is due to the extra\\ at the end of the eqnarray, which is now taken into account (... but not by dvipng apparently (*)); removing it (as shown in documented eqnarray examples, e.g.http://latexref.xyz/eqnarray.html,https://texfaq.org/FAQ-eqnarray) handles that.

(*) but hopefully we'll get rid of dvipng anyways in favor of directly rendering the glyphs ourselves; see e.g.#22459 (comment).

Edit: no, that's not enough if the last line has nonzero descent. Back to the drawing board.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@anntzeranntzer added Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text/usetex labelsSep 26, 2022
@anntzeranntzer added this to thev3.6.1 milestoneSep 26, 2022
@anntzeranntzer marked this pull request as draftSeptember 26, 2022 09:18
@oscargus
Copy link
Member

Off topic: should I file a bug report for dvipng? (The author, coincidentally, is a colleague, currently my boss...)

@anntzer
Copy link
ContributorAuthor

I don't think it's really a bug in dvipng, just a different definition of "baseline". OTOH one thing that we would look into is to usedvipng --depth... to get the baseline position? But that would require going through dvipng even for the vector backends.

@QuLogic
Copy link
Member

Edit: no, that's not enough if the last line has nonzero descent. Back to the drawing board.

Should we return to the plan of reverting the original PR?

@anntzer
Copy link
ContributorAuthor

Let's do that for now.

@QuLogicQuLogic modified the milestones:v3.6.1,v3.7.0Oct 6, 2022
@QuLogic
Copy link
Member

The original PR was reverted, so I assume you'll just put this into 3.7.

@anntzer
Copy link
ContributorAuthor

Yes.

@jklymakjklymak removed the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelJan 5, 2023
@jklymakjklymak modified the milestones:v3.7.0,v3.8.0Jan 5, 2023
@jklymak
Copy link
Member

Moved to 3.8, but feel free to argue for a back port.

@anntzer
Copy link
ContributorAuthor

No hurries, this still needs some work...

@ksundenksunden modified the milestones:v3.8.0,future releasesAug 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
future releases
Development

Successfully merging this pull request may close these issues.

[Bug]: Eqnarray in AnchoredText results in misplaced text (new in v3.6.0)
5 participants
@anntzer@oscargus@QuLogic@jklymak@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp