Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix logic error in ScalarMappable.to_rgba#11002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I think this is a candidate for backport because it fixes a un-workaroundable bug in 2.2.2. I am not 100% on that, if someone else agrees merge away! |
jklymak commentedApr 9, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I actually am 98.5% sure itsnot a followed code path because of the new clipping for imshow (#10220). 0% codecov isn't very good ;-) (i.e. max(x)>1 is always |
This is (for better or worse) a public function, I think the clipping happens when we set the data so using the 'standard' path this won't be hit, but using |
Ah, fair enough. OTOH, should it get a test if its public, including one to test if this error is properly called? But happy to see it merged if thats gilding the lily... |
This is the sort of bugfix that I think doesnot warrant a test. |
Backport PR#11002 on branch v2.2.x
PR Summary
This fixes the logic error described in#10890.