Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Description
Summary
Since#28104 now separates out hatchcolor, users should not be allowed to specifically ask to fallback to edgecolor and also explicitly set that edgecolor to none because silently falling back onedgecolor="None"
introduces the problem that:
because of eager color resolution and frequently setting "none" by knocking out the alpha, the way to check for none is checking the alpha, which leads to fallback being dependent on the interplay between alpha and edgecolor:
fallback to edgecolor rcParams doesn't check if the rcParam is also none so could sink the problem a layer deeper
Proposed fix
Deprecate this fallback behavior and raise a warning on
Rectangle( (0,0), .5, .5, hatchcolor='edge', edgecolor='None')
The alternatives are:
- set a hatchcolor
- don't set edgecolor at all, .i.e.
Rectangle( (0,0), .5, .5, hatchcolor='edge')
falls back to the rcParam inget_edgecolor