NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Commitea5d85f

committed

Add some types to _mathtext.py

Mypy 1.16.0 flags errors here:lib/matplotlib/_mathtext.py:2531: error: "Node" has no attribute "width" [attr-defined]lib/matplotlib/_mathtext.py:2608: error: List item 0 has incompatible type "Kern"; expected "Hlist | Vlist" [list-item]The check for the attribute _metrics is equivalent to checking for aninstance of Char, since only Char and its subclasses set self._metrics.Mypy infers an unnecessarily tight type list[Hlist | Vlist] forspaced_nucleus so we give it a more general one.

1 parent4f26d9a commitea5d85fCopy full SHA for ea5d85f

File tree

1 file changed

-3

lines changed

lib/matplotlib
- _mathtext.py

1 file changed

-3

lines changed

`‎lib/matplotlib/_mathtext.py`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2524,10 +2524,10 @@ def subsuper(self, s: str, loc: int, toks: ParseResults) -> T.Any:`
`2524`	`2524`	`iflen(new_children):`
`2525`	`2525`	`# remove last kern`
`2526`	`2526`	`if (isinstance(new_children[-1],Kern)and`
`2527`		`-hasattr(new_children[-2],'_metrics')):`
	`2527`	`+isinstance(new_children[-2],Char)):`
`2528`	`2528`	`new_children=new_children[:-1]`
`2529`	`2529`	`last_char=new_children[-1]`
`2530`		`-ifhasattr(last_char,'_metrics'):`
	`2530`	`+ifisinstance(last_char,Char):`
`2531`	`2531`	`last_char.width=last_char._metrics.advance`
`2532`	`2532`	`# create new Hlist without kerning`
`2533`	`2533`	`nucleus=Hlist(new_children,do_kern=False)`
`@@ -2603,7 +2603,7 @@ def subsuper(self, s: str, loc: int, toks: ParseResults) -> T.Any:`
`2603`	`2603`
`2604`	`2604`	`# Do we need to add a space after the nucleus?`
`2605`	`2605`	`# To find out, check the flag set by operatorname`
`2606`		`-spaced_nucleus= [nucleus,x]`
	`2606`	`+spaced_nucleus:list[Node]= [nucleus,x]`
`2607`	`2607`	`ifself._in_subscript_or_superscript:`
`2608`	`2608`	`spaced_nucleus+= [self._make_space(self._space_widths[r'\,'])]`
`2609`	`2609`	`self._in_subscript_or_superscript=False`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitea5d85f

File tree

1 file changed

1 file changed

`‎lib/matplotlib/_mathtext.py`

0 commit comments