Commite41d942

authored

Merge pull request#29288 from meeseeksmachine/auto-backport-of-pr-29285-on-v3.10.x

Backport PR#29285 on branch v3.10.x (Retarget PR#29175 to main)

2 parentsb4e60b6 +9f6370c commite41d942Copy full SHA for e41d942

File tree

+17

-1

lines changed

+17

-1

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1382,6 +1382,7 @@ def _generate_normals(polygons):`
`1382`	`1382`	`v2=np.empty((len(polygons),3))`
`1383`	`1383`	`forpoly_i,psinenumerate(polygons):`
`1384`	`1384`	`n=len(ps)`
	`1385`	`+ps=np.asarray(ps)`
`1385`	`1386`	`i1,i2,i3=0,n//3,2*n//3`
`1386`	`1387`	`v1[poly_i, :]=ps[i1, :]-ps[i2, :]`
`1387`	`1388`	`v2[poly_i, :]=ps[i2, :]-ps[i3, :]`

Lines changed: 16 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,11 @@`
`3`	`3`	`importmatplotlib.pyplotasplt`
`4`	`4`
`5`	`5`	`frommatplotlib.backend_basesimportMouseEvent`
`6`		`-frommpl_toolkits.mplot3d.art3dimportLine3DCollection,_all_points_on_plane`
	`6`	`+frommpl_toolkits.mplot3d.art3dimport (`
	`7`	`+Line3DCollection,`
	`8`	`+Poly3DCollection,`
	`9`	`+_all_points_on_plane,`
	`10`	`+)`
`7`	`11`
`8`	`12`
`9`	`13`	`deftest_scatter_3d_projection_conservation():`
`@@ -85,3 +89,14 @@ def test_all_points_on_plane():`
`85`	`89`	`# All points lie on a plane`
`86`	`90`	`points=np.array([[0,0,0], [0,1,0], [1,0,0], [1,1,0], [1,2,0]])`
`87`	`91`	`assert_all_points_on_plane(*points.T)`
	`92`	`+`
	`93`	`+`
	`94`	`+deftest_generate_normals():`
	`95`	`+# Smoke test for https://github.com/matplotlib/matplotlib/issues/29156`
	`96`	`+vertices= ((0,0,0), (0,5,0), (5,5,0), (5,0,0))`
	`97`	`+shape=Poly3DCollection([vertices],edgecolors='r',shade=True)`
	`98`	`+`
	`99`	`+fig=plt.figure()`
	`100`	`+ax=fig.add_subplot(projection='3d')`
	`101`	`+ax.add_collection3d(shape)`
	`102`	`+plt.draw()`

Comments

(0)