Commite0a38c6

authored

Merge pull request#27993 from ksunden/np_2_build

Unpin numpy 2, build against prerelease numpy in CIBW

2 parents8f1698f +0ec1774 commite0a38c6Copy full SHA for e0a38c6

File tree

+15

-4

lines changed

+15

-4

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -94,10 +94,10 @@ jobs:`
`94`	`94`	`runs-on:${{ matrix.os }}`
`95`	`95`	`env:`
`96`	`96`	`CIBW_BEFORE_BUILD:>-`
`97`		`- pip install certifinumpy>=1.25&&`
	`97`	`+ pip install certifi &&`
`98`	`98`	`rm -rf {package}/build`
`99`	`99`	`CIBW_BEFORE_BUILD_WINDOWS:>-`
`100`		`- pip install certifi delvewheelnumpy>=1.25&&`
	`100`	`+ pip install certifi delvewheel &&`
`101`	`101`	`rm -rf {package}/build`
`102`	`102`	`CIBW_REPAIR_WHEEL_COMMAND_WINDOWS:>-`
`103`	`103`	`delvewheel repair -w {dest_dir} {wheel}`

Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,10 +2,21 @@`
`2`	`2`	`build-backend ="setuptools.build_meta"`
`3`	`3`	`requires = [`
`4`	`4`	`"certifi>=2020.06.20",`
`5`		`-"numpy>=1.25",`
`6`	`5`	`"pybind11>=2.6",`
`7`	`6`	`"setuptools>=64",`
`8`	`7`	`"setuptools_scm>=7",`
	`8`	`+`
	`9`	`+# Comments on numpy build requirement range:`
	`10`	`+#`
	`11`	`+# 1. >=2.0.x is the numpy requirement for wheel builds for distribution`
	`12`	`+# on PyPI - building against 2.x yields wheels that are also`
	`13`	`+# ABI-compatible with numpy 1.x at runtime.`
	`14`	`+# 2. Note that building against numpy 1.x works fine too - users and`
	`15`	`+# redistributors can do this by installing the numpy version they like`
	`16`	`+# and disabling build isolation.`
	`17`	`+# 3. The <2.3 upper bound is for matching the numpy deprecation policy,`
	`18`	`+# it should not be loosened.`
	`19`	`+"numpy>=2.0.0rc1,<2.3",`
`9`	`20`	`]`
`10`	`21`
`11`	`22`	`[tool.setuptools_scm]`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -333,7 +333,7 @@ def make_release_tree(self, base_dir, files):`
`333`	`333`	`"cycler>=0.10",`
`334`	`334`	`"fonttools>=4.22.0",`
`335`	`335`	`"kiwisolver>=1.3.1",`
`336`		`-"numpy>=1.21,<2",`
	`336`	`+"numpy>=1.21",`
`337`	`337`	`"packaging>=20.0",`
`338`	`338`	`"pillow>=8",`
`339`	`339`	`"pyparsing>=2.3.1",`

Comments

(0)