Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Commita49b9d0
committed
Clean up ruff config for rules both selected and ignored
I already did configure it to use numpy style docstrings, which automatically disables several of the ignored rules (without having to specify) Thus selecting all "D" rules and only ignoring has the same effect, and cleans up the config quite a bit.Additionally, the following rules from the ignore list had only a single occurrence, so I may as well fix that occurrence and enforce the rule:- D207: Docstring is under-indented - just a single missing space in the closing `"""` for one docstring- D403: First word of the first line should be properly capitalized - No occurrences, if no objection to enforcing this going forward, may as well enable- E722: do not use bare except, specify exception instead - single occurence in tests, added a noqa comment (could alternatively add to per file ignore if we wish)Additionally, selecting all pydocstyle (`D`) enabled the previously unselected D419: Docstring is empty.There was a single occurrence of an empty docstring, in scale.py:LinearScale, which has a comment stating that the method is there explicitly to prevent inherited docstring. - noqa comment added, enforcing the rule otherwiseThe N error codes (enforcing naming conventions) that were included in the ignore list were also never selected (and selecting "N" was rather noisy even with the ignores).These have been removed1 parent5d471d6 commita49b9d0
File tree
4 files changed
+4
-52
lines changed- lib
- matplotlib
- tests
- mpl_toolkits/mplot3d
4 files changed
+4
-52
lines changedLines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
98 | 98 |
| |
99 | 99 |
| |
100 | 100 |
| |
101 |
| - | |
| 101 | + | |
102 | 102 |
| |
103 | 103 |
| |
104 | 104 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
317 | 317 |
| |
318 | 318 |
| |
319 | 319 |
| |
320 |
| - | |
| 320 | + | |
321 | 321 |
| |
322 | 322 |
| |
323 | 323 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
91 | 91 |
| |
92 | 92 |
| |
93 | 93 |
| |
94 |
| - | |
| 94 | + | |
95 | 95 |
| |
96 | 96 |
| |
97 | 97 |
| |
|
Lines changed: 1 addition & 49 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
33 | 33 |
| |
34 | 34 |
| |
35 | 35 |
| |
36 |
| - | |
37 | 36 |
| |
38 | 37 |
| |
39 |
| - | |
40 | 38 |
| |
41 | 39 |
| |
42 |
| - | |
43 |
| - | |
44 | 40 |
| |
45 | 41 |
| |
46 | 42 |
| |
47 |
| - | |
48 |
| - | |
49 | 43 |
| |
50 |
| - | |
51 |
| - | |
52 | 44 |
| |
53 | 45 |
| |
54 |
| - | |
55 |
| - | |
56 |
| - | |
57 |
| - | |
58 |
| - | |
59 | 46 |
| |
60 | 47 |
| |
61 | 48 |
| |
62 |
| - | |
63 |
| - | |
64 |
| - | |
65 |
| - | |
66 |
| - | |
67 |
| - | |
68 |
| - | |
69 |
| - | |
70 |
| - | |
71 |
| - | |
72 |
| - | |
73 |
| - | |
74 |
| - | |
75 |
| - | |
76 |
| - | |
77 |
| - | |
78 |
| - | |
79 |
| - | |
80 |
| - | |
81 |
| - | |
82 |
| - | |
83 |
| - | |
84 |
| - | |
85 |
| - | |
86 |
| - | |
87 |
| - | |
88 |
| - | |
89 |
| - | |
90 |
| - | |
91 |
| - | |
92 |
| - | |
93 |
| - | |
94 |
| - | |
95 |
| - | |
96 |
| - | |
97 |
| - | |
| 49 | + | |
98 | 50 |
| |
99 | 51 |
| |
100 | 52 |
| |
|
0 commit comments
Comments
(0)