Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

NAVAND-1311: introduce violated section in route line#7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dzinad wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromNAVAND-1311-dd

Conversation

@dzinad
Copy link
Contributor

@dzinaddzinad commentedApr 20, 2023•
edited
Loading

No description provided.

@github-actions
Copy link

github-actionsbot commentedApr 20, 2023•
edited
Loading

Changelog

Features

  • AddedMapboxRouteLineOptions#displayViolatedSections option andRouteLineColorResources#violatedSectionColor,RouteLineColorResources#alternativeRouteViolatedSectionColor,RouteLineResources#violatedSectionDashArray,RouteLineResources#violatedSectionOpacity,RouteLineResources#violatedSectionLineWidth to modify the route line style of violated sections. The section is considered violated when some of the restricting request parameters (e. g.maxHeight,maxWidth,exclude, etc.) were violated.[#dd](https://github.com/mapbox/mapbox-navigation-android/pull/dd)

Bug fixes and improvements

Known issues⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@dzinaddzinad changed the titletmpNAVAND-1311: introduce violated section in route lineMay 2, 2023
@dzinaddzinad marked this pull request as ready for reviewMay 2, 2023 11:16
@cafesilencio
Copy link

How is this different from route restrictions? Is there any context available regarding the feature requirements for this?

@dzinad
Copy link
ContributorAuthor

How is this different from route restrictions? Is there any context available regarding the feature requirements for this?

It's based on different data.
More about route notifications with design mockups:https://docs.google.com/document/d/1VPyj31D5SWCKSMATqXKt6OFCJnfB9gQFYFGQt-oB2SA/edit#heading=h.1s8fyfwsyhjo

version= [
mapboxMapSdk :'10.13.0-rc.1',
mapboxSdkServices :'6.11.0',
mapboxSdkServices :'6.12.0-dzina',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's make sure this doesn't get merged.

@cafesilencio
Copy link

I'm not able to run the QA app. from this branch. I'm guessing it's because ofmapboxSdkServices : '6.12.0-dzina'. Is there another way to test this feature?

val startRouteLineDistance= legDistances?.getOrNull(startIndex)
val endRouteLineDistance= legDistances?.getOrNull(endIndex)
if (startRouteLineDistance!=null&& endRouteLineDistance!=null) {
val startOffset=1.0- startRouteLineDistance.distanceRemaining/ routeDistance!!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If granularDistances above is nullable doesn't that also mean granularDistances?.completeDistance can be null? Here you're assuming it won't be.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

But then startRouteLineDistance would be null and we wouldn't have entered this branch.

@dzinad
Copy link
ContributorAuthor

I'm not able to run the QA app. from this branch. I'm guessing it's because of mapboxSdkServices : '6.12.0-dzina'. Is there another way to test this feature?

Unfortunately I can't merge mapbox-java PR and release it until it's all ready on server-side.
You can assemble mapbox-java from here:mapbox/mapbox-java#1542

@temaptemap requested a review froma team as acode ownerMarch 6, 2025 15:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@LukasPaczosLukasPaczosAwaiting requested review from LukasPaczos

1 more reviewer

@cafesilenciocafesilenciocafesilencio left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dzinad@cafesilencio
[8]ページ先頭
©2009-2025 Movatter.jp