Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DirectionsRoute to NavigationRoute refactoring#6516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
RingerJK wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromkyv-navigation-route-create-from-directions-route

Conversation

@RingerJK
Copy link
Contributor

@RingerJKRingerJK commentedOct 27, 2022•
edited
Loading

Description

blocked by#6005

Squashed commits:[f265764b67] Revert "- Added Waypoints to NavigationRoute; - RouteOptionsUpdater refactored."This reverts commit b111ebe6f3b3396fa14212e88f2316ccc76f3cac.[250633f2c7] NavigationRoute: create from DirectionsRoute(s)[b111ebe6f3] - Added Waypoints to NavigationRoute; - RouteOptionsUpdater refactored.
@RingerJKRingerJK self-assigned thisOct 27, 2022
@RingerJKRingerJK added the skip changelogShould not be added into version changelog. labelOct 27, 2022
@dzinad
Copy link
Contributor

I think it's unblocked now.

}
}

internalfuncreate(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this used only for tests? Now it looks like it. Why can't you do all these json manipulations directly in the test-only method? For example, inNavigationRouteEx.
I don't like adding this method to production code because it duplicates directions response structure. And now the knowledge of this structure only lives in mapbox-java, which I think is good and it should stay this way.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dzinaddzinaddzinad left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@RingerJKRingerJK

Labels

skip changelogShould not be added into version changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RingerJK@dzinad
[8]ページ先頭
©2009-2025 Movatter.jp