- Notifications
You must be signed in to change notification settings - Fork3k
refactor: actions icon migration#8219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:preview
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coderabbitaibot commentedDec 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 109 files out of 216 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR migrates icons fromlucide-react to the internal@plane/propel/icons library, focusing on commonly used action icons. The migration introduces a consistent icon naming pattern and updates the icon registry to support the new icon set.
Key Changes
- Icon Migration: Replaced 10+ lucide-react icons with custom Propel icons (CheckIcon, SearchIcon, PlusIcon, TrashIcon, EditIcon, NewTabIcon, LockIcon, GlobeIcon, CopyIcon, LinkIcon, InfoIcon)
- Icon Registry: Updated
packages/propel/src/icons/registry.tsto include all migrated icons with proper namespacing (e.g., "action.check", "action.search") - Type Definitions: Updated type signatures to support union types
LucideIcon | React.FC<ISvgIcons>for compatibility during migration
Reviewed changes
Copilot reviewed 216 out of 216 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/propel/src/icons/actions/*.tsx | Added 9 new icon components (CheckIcon, CopyIcon, EditIcon, GlobeIcon, LinkIcon, LockIcon, NewTabIcon, PlusIcon, TrashIcon) |
packages/propel/src/icons/misc/info-icon.tsx | Moved InfoIcon from root to misc directory with proper structure |
packages/propel/src/icons/registry.ts | Updated icon registry with new action icons and organized imports by category |
packages/propel/src/icons/constants.tsx | Added new icons to ActionsIconsMap and created MiscIconsMap |
packages/ui/src/constants/icons.ts | Updated LUCIDE_ICONS_LIST to use new Propel icons instead of lucide-react |
packages/ui/src/dropdowns/*.tsx | Migrated Check → CheckIcon and Search → SearchIcon across dropdown components |
packages/ui/src/dropdown/common/*.tsx | Updated icon imports and usage in common dropdown utilities |
packages/editor/src/core/extensions/table/*.tsx | Migrated Copy → CopyIcon and Trash2 → TrashIcon in table drag handle dropdowns |
packages/editor/src/core/extensions/custom-image/*.tsx | Migrated Plus → PlusIcon and ExternalLink → NewTabIcon in image toolbar |
packages/editor/src/core/extensions/code/*.tsx | Updated CopyIcon import from lucide-react to @plane/propel/icons |
packages/editor/src/core/components/menus/*.tsx | Migrated Check → CheckIcon, Link → LinkIcon, Trash2 → TrashIcon in menu components |
packages/editor/src/core/components/links/*.tsx | Updated icon imports for link preview and editing |
apps/web/helpers/views.helper.ts | Updated view access icons (Globe2 → GlobeIcon, Lock → LockIcon) with type changes |
apps/web/core/components/workspace/**/*.tsx | Migrated icons across workspace views, settings, and sidebar components |
apps/web/core/components/views/*.tsx | Updated Check → CheckIcon in view filters and list components |
apps/web/core/components/project/**/*.tsx | Migrated icons in project cards, forms, settings, and dropdowns |
apps/web/core/components/pages/**/*.tsx | Updated icon usage in page lists, filters, forms, and actions |
apps/web/core/components/issues/**/*.tsx | Comprehensive icon migration across issue layouts, properties, and detail widgets |
apps/web/core/components/modules/**/*.tsx | Updated icons in module views, dropdowns, and analytics sidebar |
apps/web/core/components/cycles/**/*.tsx | Migrated icons in cycle views, filters, and transfer modals |
apps/web/core/components/inbox/*.tsx | Updated icons in inbox filters, status, and issue headers |
apps/web/core/components/estimates/*.tsx | Migrated Check → CheckIcon and Pencil → EditIcon in estimate point components |
apps/web/core/components/home/**/*.tsx | Updated PlusIcon usage in home widget components |
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Description
This PR includes the following updates:
Changes