- Notifications
You must be signed in to change notification settings - Fork102
Fixed xyz bug in ConfigurationManager#2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
GiraldoNainggolan wants to merge4 commits intomagento:5.4.0-developChoose a base branch
base:5.4.0-develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fixed xyz bug in ConfigurationManager#2492
GiraldoNainggolan wants to merge4 commits intomagento:5.4.0-developfromGiraldoNainggolan:fix-bug-ConfigurasiManager
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
VitaliyBoyko commentedFeb 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@GiraldoNainggolan please sign the CLA agreement, address test issues, and remove .history/* |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the ConfigurasiManager module of the Magento 2 PhpStorm plugin. Previously, there was an issue with configuration parsing that caused incorrect processing, preventing proper loading. This update ensures that configurations are correctly parsed and loaded without errors. The changes include fixing the parsing logic, adding validation to ensure the retrieved values meet expectations, and improving code readability. To test this update, install the latest version of the plugin, open PhpStorm, navigate to the plugin settings, and verify that configurations load correctly without errors. Additionally, check the parsing process to ensure it runs smoothly without generating unnecessary logs.